Skip to content

Commit 10e2583

Browse files
authored
Move test that imports SDK from the API (open-telemetry#1185)
1 parent e50e3a8 commit 10e2583

File tree

3 files changed

+25
-19
lines changed

3 files changed

+25
-19
lines changed

opentelemetry-api/tests/trace/test_globals.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import unittest
2-
from logging import WARNING
32
from unittest.mock import patch
43

54
from opentelemetry import context, trace
6-
from opentelemetry.sdk.trace import TracerProvider # type:ignore
75

86

97
class TestGlobals(unittest.TestCase):
@@ -22,23 +20,6 @@ def test_get_tracer(self):
2220
trace.get_tracer("foo", "var", mock_provider)
2321
mock_provider.get_tracer.assert_called_with("foo", "var")
2422

25-
def test_tracer_provider_override_warning(self):
26-
"""trace.set_tracer_provider should throw a warning when overridden"""
27-
trace.set_tracer_provider(TracerProvider())
28-
tracer_provider = trace.get_tracer_provider()
29-
with self.assertLogs(level=WARNING) as test:
30-
trace.set_tracer_provider(TracerProvider())
31-
self.assertEqual(
32-
test.output,
33-
[
34-
(
35-
"WARNING:opentelemetry.trace:Overriding of current "
36-
"TracerProvider is not allowed"
37-
)
38-
],
39-
)
40-
self.assertIs(tracer_provider, trace.get_tracer_provider())
41-
4223

4324
class TestTracer(unittest.TestCase):
4425
def setUp(self):
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# type:ignore
2+
import unittest
3+
from logging import WARNING
4+
5+
from opentelemetry import trace
6+
from opentelemetry.sdk.trace import TracerProvider # type:ignore
7+
8+
9+
class TestGlobals(unittest.TestCase):
10+
def test_tracer_provider_override_warning(self):
11+
"""trace.set_tracer_provider should throw a warning when overridden"""
12+
trace.set_tracer_provider(TracerProvider())
13+
tracer_provider = trace.get_tracer_provider()
14+
with self.assertLogs(level=WARNING) as test:
15+
trace.set_tracer_provider(TracerProvider())
16+
self.assertEqual(
17+
test.output,
18+
[
19+
(
20+
"WARNING:opentelemetry.trace:Overriding of current "
21+
"TracerProvider is not allowed"
22+
)
23+
],
24+
)
25+
self.assertIs(tracer_provider, trace.get_tracer_provider())

0 commit comments

Comments
 (0)