Skip to content

Commit 4674973

Browse files
authored
Change imports to avoid pylint namespace errors (open-telemetry#376)
1 parent 3995075 commit 4674973

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@
8080
https://docs.python.org/3/tutorial/floatingpoint.html
8181
"""
8282

83+
# TODO: make pylint use 3p opentracing module for type inference
84+
# pylint:disable=no-member
85+
8386
import logging
8487

8588
import opentracing
@@ -266,7 +269,7 @@ def log(self, **kwargs):
266269
def log_event(self, event, payload=None):
267270
super().log_event(event, payload=payload)
268271

269-
def set_baggage_item(self, key, value):
272+
def set_baggage_item(self, key, value): # pylint:disable=unused-argument
270273
"""Implements the ``set_baggage_item()`` method from the base class.
271274
272275
Warning:
@@ -279,7 +282,7 @@ def set_baggage_item(self, key, value):
279282
)
280283
# TODO: Implement.
281284

282-
def get_baggage_item(self, key):
285+
def get_baggage_item(self, key): # pylint:disable=unused-argument
283286
"""Implements the ``get_baggage_item()`` method from the base class.
284287
285288
Warning:

ext/opentelemetry-ext-opentracing-shim/tests/test_shim.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15+
# TODO: make pylint use 3p opentracing module for type inference
16+
# pylint:disable=no-member
17+
1518
import time
1619
from unittest import TestCase
1720

0 commit comments

Comments
 (0)