Skip to content

Commit 753ec6c

Browse files
authored
Add some repr()s to basic trace types. (open-telemetry#1485)
1 parent 1cc23e0 commit 753ec6c

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2828
([#1420](https://github.com/open-telemetry/opentelemetry-python/pull/1420))
2929
- `opentelemetry-exporter-zipkin` Add support for array attributes in Span and Resource exports
3030
([#1285](https://github.com/open-telemetry/opentelemetry-python/pull/1285))
31+
- Added `__repr__` for `DefaultSpan`, added `trace_flags` to `__repr__` of
32+
`SpanContext` ([#1485](https://github.com/open-telemetry/opentelemetry-python/pull/1485)])
3133

3234
## [0.16b1](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v0.16b1) - 2020-11-26
3335
### Added

opentelemetry-api/src/opentelemetry/trace/span.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,12 @@ def __delattr__(self, *args: str) -> None:
237237

238238
def __repr__(self) -> str:
239239
return (
240-
"{}(trace_id={}, span_id={}, trace_state={!r}, is_remote={})"
240+
"{}(trace_id={}, span_id={}, trace_flags=0x{:02x}, trace_state={!r}, is_remote={})"
241241
).format(
242242
type(self).__name__,
243243
format_trace_id(self.trace_id),
244244
format_span_id(self.span_id),
245+
self.trace_flags,
245246
self.trace_state,
246247
self.is_remote,
247248
)
@@ -291,6 +292,9 @@ def record_exception(
291292
) -> None:
292293
pass
293294

295+
def __repr__(self) -> str:
296+
return "DefaultSpan({!r})".format(self._context)
297+
294298

295299
INVALID_SPAN_ID = 0x0000000000000000
296300
INVALID_TRACE_ID = 0x00000000000000000000000000000000

0 commit comments

Comments
 (0)