Code cleanup (open-telemetry#1503)

srikanthccv · web-flow · commit 90db9dc30609 · 2021-01-04T12:57:26.000-08:00
diff --git a/opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py b/opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
@@ -40,34 +40,13 @@ def http_status_to_status_code(
     Args:
         status (int): HTTP status code
     """
-    # pylint:disable=too-many-branches,too-many-return-statements
     # See: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
     if status < 100:
         return StatusCode.ERROR
     if status <= 299:
         return StatusCode.UNSET
-    if status <= 399:
-        if allow_redirect:
-            return StatusCode.UNSET
-        return StatusCode.ERROR
-    if status <= 499:
-        if status == 401:  # HTTPStatus.UNAUTHORIZED:
-            return StatusCode.ERROR
-        if status == 403:  # HTTPStatus.FORBIDDEN:
-            return StatusCode.ERROR
-        if status == 404:  # HTTPStatus.NOT_FOUND:
-            return StatusCode.ERROR
-        if status == 429:  # HTTPStatus.TOO_MANY_REQUESTS:
-            return StatusCode.ERROR
-        return StatusCode.ERROR
-    if status <= 599:
-        if status == 501:  # HTTPStatus.NOT_IMPLEMENTED:
-            return StatusCode.ERROR
-        if status == 503:  # HTTPStatus.SERVICE_UNAVAILABLE:
-            return StatusCode.ERROR
-        if status == 504:  # HTTPStatus.GATEWAY_TIMEOUT:
-            return StatusCode.ERROR
-        return StatusCode.ERROR
+    if status <= 399 and allow_redirect:
+        return StatusCode.UNSET
     return StatusCode.ERROR
 
 
