feat(lsp): Don't show clients with empty diagnostic content in hover

joshbode · joshbode · commit 2f47401a2a3e · 2025-04-28T21:13:07.000+10:00
*Problem*:

LSP clients that produced no diagnostic results are being shown in the
diagnostics hover (e.g. the client name is shown with no results).

*Solution*:

This PR hides clients with no diagnostic content by default, with a
boolean option `keep_empty` added to retain the existing behaviour.
diff --git a/runtime/doc/lsp.txt b/runtime/doc/lsp.txt
@@ -1579,7 +1579,9 @@ the current buffer.
 
 
     Fields: ~
-      • {silent}?  (`boolean`)
+      • {silent}?      (`boolean`)
+      • {keep_empty}?  (`boolean`) Show clients in hover that produced no
+                       diagnostics.
 
 *vim.lsp.buf.signature_help.Opts*
     Extends: |vim.lsp.util.open_floating_preview.Opts|
diff --git a/runtime/lua/vim/lsp/buf.lua b/runtime/lua/vim/lsp/buf.lua
@@ -27,6 +27,7 @@ local hover_ns = api.nvim_create_namespace('nvim.lsp.hover_range')
 
 --- @class vim.lsp.buf.hover.Opts : vim.lsp.util.open_floating_preview.Opts
 --- @field silent? boolean
+--- @field keep_empty? boolean Show clients in hover that produced no diagnostics.
 
 --- Displays hover information about the symbol under the cursor in a floating
 --- window. The window will be dismissed on cursor move.
@@ -61,11 +62,16 @@ function M.hover(config)
     local results1 = {} --- @type table<integer,lsp.Hover>
 
     for client_id, resp in pairs(results) do
+      --- @type lsp.ResponseError, lsp.Hover
       local err, result = resp.err, resp.result
       if err then
         lsp.log.error(err.code, err.message)
       elseif result then
-        results1[client_id] = result
+        local contents = result.contents
+        if config.keep_empty == true or
+            contents.kind or contents.language or contents[1] then
+          results1[client_id] = result
+        end
       end
     end
 
