fix(lsp): don't show clients with empty diagnostic content in hover

joshbode · joshbode · commit 313e543d3f0a · 2025-04-30T08:20:03.000+10:00
*Problem*:

LSP clients that produced no diagnostic results are being shown in the
diagnostics hover (e.g. the client name is shown with no results).

*Solution*:

This PR hides clients with no diagnostic content in the hover summary.
diff --git a/runtime/lua/vim/lsp/buf.lua b/runtime/lua/vim/lsp/buf.lua
@@ -61,11 +61,15 @@ function M.hover(config)
     local results1 = {} --- @type table<integer,lsp.Hover>
 
     for client_id, resp in pairs(results) do
+      --- @type lsp.ResponseError, lsp.Hover
       local err, result = resp.err, resp.result
       if err then
         lsp.log.error(err.code, err.message)
       elseif result then
-        results1[client_id] = result
+        -- Ensure that there is some non-empty content to display
+        if #result.contents > 0 then
+          results1[client_id] = result
+        end
       end
     end
 
