support for 'payload' of notification in postgres >=9.0

brianc · brianc · commit e4ce36bda800 · 2011-04-14T22:53:44.000-05:00
diff --git a/src/binding.cc b/src/binding.cc
@@ -34,6 +34,8 @@ static Persistent<String> routine_symbol;
 static Persistent<String> name_symbol;
 static Persistent<String> value_symbol;
 static Persistent<String> type_symbol;
+static Persistent<String> channel_symbol;
+static Persistent<String> payload_symbol;
 
 class Connection : public EventEmitter {
 
@@ -70,6 +72,8 @@ class Connection : public EventEmitter {
     name_symbol = NODE_PSYMBOL("name");
     value_symbol = NODE_PSYMBOL("value");
     type_symbol = NODE_PSYMBOL("type");
+    channel_symbol = NODE_PSYMBOL("channel");
+    payload_symbol = NODE_PSYMBOL("payload");
 
 
     NODE_SET_PROTOTYPE_METHOD(t, "connect", Connect);
@@ -390,7 +394,8 @@ class Connection : public EventEmitter {
       PGnotify *notify;
       while ((notify = PQnotifies(connection_))) {
         Local<Object> result = Object::New();
-        result->Set(String::New("channel"), String::New(notify->relname));
+        result->Set(channel_symbol, String::New(notify->relname));
+        result->Set(payload_symbol, String::New(notify->extra));
         Handle<Value> res = (Handle<Value>)result;
         Emit((Handle<String>)String::New("notification"), 1, &res);
         PQfreemem(notify);
diff --git a/test/integration/client/notice-tests.js b/test/integration/client/notice-tests.js
@@ -16,10 +16,16 @@ test('emits notify message', function() {
   client.query('LISTEN boom', assert.calls(function() {
     var otherClient = helper.client();
     otherClient.query('LISTEN boom', assert.calls(function() {
-      client.query('NOTIFY boom');
+      client.query("NOTIFY boom, 'omg!'");
       assert.emits(client, 'notification', function(msg) {
-        assert.equal(msg.channel, 'boom');
-        client.end()
+        
+        //make sure PQfreemem doesn't invalidate string pointers
+        setTimeout(function() {
+          assert.equal(msg.channel, 'boom');
+          assert.ok(msg.payload == 'omg!' /*9.x*/ || msg.payload == '' /*8.x*/, "expected blank payload or correct payload but got " + msg.message)
+          client.end()
+        }, 500)
+
       });
       assert.emits(otherClient, 'notification', function(msg) {
         assert.equal(msg.channel, 'boom');
