Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

Improve logs when Functions/publish directories are specified #97

Closed
ehmicky opened this issue Nov 18, 2020 · 1 comment · Fixed by #100
Closed

Improve logs when Functions/publish directories are specified #97

ehmicky opened this issue Nov 18, 2020 · 1 comment · Fixed by #100
Assignees
@ehmicky
Labels
proj/non/next-on-netlify-enterprise type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Nov 18, 2020 •
edited
Loading

When publishPath is specified, we should not print:

next-on-netlify/lib/steps/prepareFolders.js

Line 9 in 66cc4ce

log(" ", "Publish directory: ", publishPath);

since this is most likely taken from the site's already configured publish path, and the user would expect that to be used.

When functionsPath is specified, we should not print:

next-on-netlify/lib/steps/prepareFolders.js

Line 8 in 66cc4ce

log(" ", "Functions directory: ", functionsPath);

If both are specified, we should not print:

next-on-netlify/lib/steps/prepareFolders.js

Line 10 in 66cc4ce

log(" ", "Make sure these are set in your netlify.toml file.");

@ehmicky ehmicky added type: feature code contributing to the implementation of a feature and/or user facing functionality proj/non/next-on-netlify-enterprise labels Nov 18, 2020
@ehmicky ehmicky self-assigned this Nov 23, 2020
@ehmicky ehmicky mentioned this issue Nov 23, 2020
Merged
@ehmicky
Copy link
Contributor Author

ehmicky commented Nov 23, 2020

Fixed by #100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ehmicky ehmicky

Labels
proj/non/next-on-netlify-enterprise type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve logs when Functions/publish directories are specified netlify/next-on-netlify
1 participant
@ehmicky