Changes return type of ignoreElements to Completable. ReactiveX#1436

kzaher · kzaher · commit 69ae3520f55c · 2017-10-07T17:29:26.000+02:00
diff --git a/RxSwift/Observables/Filter.swift b/RxSwift/Observables/Filter.swift
@@ -32,10 +32,11 @@ extension ObservableType {
      - returns: An observable sequence that skips all elements of the source sequence.
      */
     public func ignoreElements()
-        -> Observable<E> {
-            return filter { _ -> Bool in
-                return false
+        -> Completable {
+            return flatMap { _ in
+                return Observable<Never>.empty()
             }
+            .asCompletable()
     }
 }
 
diff --git a/Tests/RxSwiftTests/Observable+FilterTests.swift b/Tests/RxSwiftTests/Observable+FilterTests.swift
@@ -233,7 +233,7 @@ extension ObservableFilterTest {
             ])
 
         let res = scheduler.start {
-            xs.ignoreElements()
+            (xs.ignoreElements() as Completable).asObservable()
         }
 
         XCTAssertEqual(res.events, [

Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,11 @@ extension ObservableType {`
`32`	`32`	`- returns: An observable sequence that skips all elements of the source sequence.`
`33`	`33`	`*/`
`34`	`34`	`public func ignoreElements()`
`35`		`- -> Observable<E> {`
`36`		`- return filter { _ -> Bool in`
`37`		`- return false`
	`35`	`+ -> Completable {`
	`36`	`+ return flatMap { _ in`
	`37`	`+ return Observable<Never>.empty()`
`38`	`38`	`}`
	`39`	`+ .asCompletable()`
`39`	`40`	`}`
`40`	`41`	`}`
`41`	`42`
Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ extension ObservableFilterTest {`
`233`	`233`	`])`
`234`	`234`
`235`	`235`	`let res = scheduler.start {`
`236`		`- xs.ignoreElements()`
	`236`	`+ (xs.ignoreElements() as Completable).asObservable()`
`237`	`237`	`}`
`238`	`238`
`239`	`239`	`XCTAssertEqual(res.events, [`