Skip to content

Commit 248919f

Browse files
authored
More Travis deploy script fixes (flutter#14549)
* More restricted versioning on iOS * Escape the key base64 and don't echo it back on travis * Have match not print back the cert url
1 parent 97e7793 commit 248919f

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

dev/bots/travis_setup.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@ if [ -n "$TRAVIS" ]; then
2525
export ANDROID_HOME=`pwd`/android-sdk
2626
export PATH=`pwd`/android-sdk/tools/bin:$PATH
2727
mkdir -p /home/travis/.android # silence sdkmanager warning
28+
set +x # Travis's env variable hiding is a bit wonky. Don't echo back this line.
2829
if [ -n "$ANDROID_GALLERY_UPLOAD_KEY" ]; then
29-
echo $ANDROID_GALLERY_UPLOAD_KEY | base64 --decode > /home/travis/.android/debug.keystore
30+
echo "$ANDROID_GALLERY_UPLOAD_KEY" | base64 --decode > /home/travis/.android/debug.keystore
3031
fi
32+
set -x
3133
echo 'count=0' > /home/travis/.android/repositories.cfg # silence sdkmanager warning
3234
# suppressing output of sdkmanager to keep log under 4MB (travis limit)
3335
echo y | sdkmanager "tools" >/dev/null

examples/flutter_gallery/ios/fastlane/Fastfile

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,21 @@ platform :ios do
1515
# Doesn't do anything when not on Travis.
1616
setup_travis
1717

18+
# Relative to this file.
19+
raw_version = File.read('../../../../version')
20+
puts "Building and deploying version #{raw_version}..."
21+
1822
increment_version_number(
19-
# Relative to this file. Accept only digits and dots.
20-
version_number: File.read('../../../../version').gsub(/[^0-9\.]/, '')
23+
# Only major, minor, patch digits and dots.
24+
version_number: /\d+\.\d+\.\d+/.match(raw_version)[0]
2125
)
2226

2327
# Retrieves all the necessary certs and provisioning profiles.
2428
sync_code_signing(
2529
git_url: ENV['PUBLISHING_MATCH_CERTIFICATE_REPO'],
2630
type: 'appstore',
27-
readonly: true
31+
readonly: true,
32+
verbose: false
2833
)
2934

3035
# Modify the Xcode project to use the new team and profile.

0 commit comments

Comments
 (0)