fix(PasswordBox): Override platform defaults for MinWidth and MinHeight (microsoft#1510) (microsoft#1513)

rozele · web-flow · commit 4bbd1fdba78f · 2017-11-16T16:40:07.000-05:00
The default `MinWidth` and `MinHeight` for TextBox is 64 x 32. Overriding these values in the `SetDimensions` method to ensure the `TextBox` abides by the layout specified by Yoga. This is reasonably safe because Yoga has it's own implementation of `minWidth` and `minHeight`. Fixes microsoft#1369
diff --git a/ReactWindows/ReactNative/Views/TextInput/ReactPasswordBoxManager.cs b/ReactWindows/ReactNative/Views/TextInput/ReactPasswordBoxManager.cs
@@ -399,10 +399,9 @@ public override void OnDropViewInstance(ThemedReactContext reactContext, Passwor
         /// <param name="dimensions">The output buffer.</param>
         public override void SetDimensions(PasswordBox view, Dimensions dimensions)
         {
-            Canvas.SetLeft(view, dimensions.X);
-            Canvas.SetTop(view, dimensions.Y);
-            view.Width = dimensions.Width;
-            view.Height = dimensions.Height;
+            base.SetDimensions(view, dimensions);
+            view.MinWidth = dimensions.Width;
+            view.MinHeight = dimensions.Height;
         }
 
         private void OnPasswordChanged(object sender, RoutedEventArgs e)

Original file line number	Diff line number	Diff line change
`@@ -399,10 +399,9 @@ public override void OnDropViewInstance(ThemedReactContext reactContext, Passwor`
`399`	`399`	`/// <param name="dimensions">The output buffer.</param>`
`400`	`400`	`public override void SetDimensions(PasswordBox view, Dimensions dimensions)`
`401`	`401`	`{`
`402`		`- Canvas.SetLeft(view, dimensions.X);`
`403`		`- Canvas.SetTop(view, dimensions.Y);`
`404`		`- view.Width = dimensions.Width;`
`405`		`- view.Height = dimensions.Height;`
	`402`	`+ base.SetDimensions(view, dimensions);`
	`403`	`+ view.MinWidth = dimensions.Width;`
	`404`	`+ view.MinHeight = dimensions.Height;`
`406`	`405`	`}`
`407`	`406`
`408`	`407`	`private void OnPasswordChanged(object sender, RoutedEventArgs e)`