Enable Images to have muliple <Text> ancestors (microsoft#749)

rigdern · rozele · commit 726d11394005 · 2016-10-07T10:04:11.000-04:00
Prior to this change, Images with one &lt;Text&gt; ancestor were supported:

```
&lt;Text&gt;
  &lt;Image /&gt;
&lt;/Text&gt;
```

But Images with multiple &lt;Text&gt; ancestors resulted in an exception:

```
&lt;Text&gt;
  &lt;Text&gt;
    &lt;Image /&gt;
  &lt;/Text&gt;
&lt;/Text&gt;
```

This change fixes the latter scenario.

The problem was that some code assumed that it would only receive Inlines when actually it could also receive UIElements.
diff --git a/ReactWindows/ReactNative/Views/Text/ReactSpanViewManager.cs b/ReactWindows/ReactNative/Views/Text/ReactSpanViewManager.cs
@@ -59,8 +59,17 @@ public void SetColor(Span view, uint? color)
         public void AddView(DependencyObject parent, DependencyObject child, int index)
         {
             var span = (Span)parent;
-            var inline = (Inline)child;
-            span.Inlines.Insert(index, inline);
+
+            var inlineChild = child as Inline;
+            if (inlineChild == null)
+            {
+                inlineChild = new InlineUIContainer
+                {
+                    Child = (UIElement)child,
+                };
+            }
+
+            span.Inlines.Insert(index, inlineChild);
         }
 
         /// <summary>
@@ -87,7 +96,16 @@ public override ReactSpanShadowNode CreateShadowNodeInstance()
         public DependencyObject GetChildAt(DependencyObject parent, int index)
         {
             var span = (Span)parent;
-            return span.Inlines[index];
+            var child = span.Inlines[index];
+            var childInlineContainer = child as InlineUIContainer;
+            if (childInlineContainer != null)
+            {
+                return childInlineContainer.Child;
+            }
+            else
+            {
+                return child;
+            }
         }
 
         /// <summary>
