fix(OnSuspend): Reset ReactChoreographer when app suspends (microsoft#1487)

rozele · web-flow · commit 81c9361aecda · 2017-11-03T09:04:17.000-04:00
ReactChoreographer needs to be reset to ensure that additional operations aren't enqueued on the dispatcher. Fixes microsoft#1474
diff --git a/ReactWindows/ReactNative.Shared/ReactInstanceManager.cs b/ReactWindows/ReactNative.Shared/ReactInstanceManager.cs
@@ -247,6 +247,7 @@ public void OnSuspend()
 
             MoveToBeforeResumeLifecycleState();
 
+            ReactChoreographer.Dispose();
             DispatcherHelpers.Reset();
         }
 
@@ -279,6 +280,7 @@ public void OnResume(Action onBackPressed)
         {
             DispatcherHelpers.Initialize();
             DispatcherHelpers.AssertOnDispatcher();
+            ReactChoreographer.Initialize();
 
             _defaultBackButtonHandler = onBackPressed;
             _suspendCancellation = new CancellationDisposable();

Original file line number	Diff line number	Diff line change
`@@ -247,6 +247,7 @@ public void OnSuspend()`
`247`	`247`
`248`	`248`	`MoveToBeforeResumeLifecycleState();`
`249`	`249`
	`250`	`+ ReactChoreographer.Dispose();`
`250`	`251`	`DispatcherHelpers.Reset();`
`251`	`252`	`}`
`252`	`253`
`@@ -279,6 +280,7 @@ public void OnResume(Action onBackPressed)`
`279`	`280`	`{`
`280`	`281`	`DispatcherHelpers.Initialize();`
`281`	`282`	`DispatcherHelpers.AssertOnDispatcher();`
	`283`	`+ ReactChoreographer.Initialize();`
`282`	`284`
`283`	`285`	`_defaultBackButtonHandler = onBackPressed;`
`284`	`286`	`_suspendCancellation = new CancellationDisposable();`