fix(Timing): Fix behavior for requestAnimationFrame.

rozele · rozele · commit afeb037f2d21 · 2016-05-16T15:13:20.000-04:00
Previously, the requestAnimationFrame callbacks occured on a tight loop. Ensuring that only immediate timers callback instantly. Fixes microsoft#394
diff --git a/ReactWindows/ReactNative/Modules/Core/Timing.cs b/ReactWindows/ReactNative/Modules/Core/Timing.cs
@@ -106,16 +106,16 @@ public void createTimer(
             double jsSchedulingTime,
             bool repeat)
         {
-            var period = TimeSpan.FromMilliseconds(duration);
-            var scheduledTime = DateTimeOffset.FromUnixTimeMilliseconds((long)jsSchedulingTime);
-            var initialTargetTime = (scheduledTime + period);
-
-            if (DateTimeOffset.Now > initialTargetTime && !repeat)
+            if (duration == 0 && !repeat)
             {
                 _jsTimersModule.callTimers(new[] { callbackId });
                 return;
             }
 
+            var period = TimeSpan.FromMilliseconds(duration);
+            var scheduledTime = DateTimeOffset.FromUnixTimeMilliseconds((long)jsSchedulingTime);
+            var initialTargetTime = (scheduledTime + period);
+
             var timer = new TimerData(callbackId, initialTargetTime, period, repeat);
             lock (_gate)
             {

Original file line number	Diff line number	Diff line change
`@@ -106,16 +106,16 @@ public void createTimer(`
`106`	`106`	`double jsSchedulingTime,`
`107`	`107`	`bool repeat)`
`108`	`108`	`{`
`109`		`- var period = TimeSpan.FromMilliseconds(duration);`
`110`		`- var scheduledTime = DateTimeOffset.FromUnixTimeMilliseconds((long)jsSchedulingTime);`
`111`		`- var initialTargetTime = (scheduledTime + period);`
`112`		`-`
`113`		`- if (DateTimeOffset.Now > initialTargetTime && !repeat)`
	`109`	`+ if (duration == 0 && !repeat)`
`114`	`110`	`{`
`115`	`111`	`_jsTimersModule.callTimers(new[] { callbackId });`
`116`	`112`	`return;`
`117`	`113`	`}`
`118`	`114`
	`115`	`+ var period = TimeSpan.FromMilliseconds(duration);`
	`116`	`+ var scheduledTime = DateTimeOffset.FromUnixTimeMilliseconds((long)jsSchedulingTime);`
	`117`	`+ var initialTargetTime = (scheduledTime + period);`
	`118`	`+`
`119`	`119`	`var timer = new TimerData(callbackId, initialTargetTime, period, repeat);`
`120`	`120`	`lock (_gate)`
`121`	`121`	`{`