Skip to content

Commit d49294f

Browse files
matthargettmatthargett
committed
Finish adding tests from upstream. Hoist variables and use Tuple Types to prepare for massive reduction of duplication in new tests. (Will apply to old tests in different PR.) Next steps: Deduplicate, add assertions for increment/decrement JS calls.
1 parent 1626a72 commit d49294f

File tree

4 files changed

+234
-216
lines changed

4 files changed

+234
-216
lines changed

‎ReactWindows/ReactNative.Net46.Tests/ReactNative.Net46.Tests.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,9 @@
127127
<Reference Include="System.Reactive.Windows.Threading, Version=3.0.1000.0, Culture=neutral, PublicKeyToken=94bc3704cddfc263, processorArchitecture=MSIL">
128128
<HintPath>..\packages\System.Reactive.Windows.Threading.4.0.0-preview00001\lib\net45\System.Reactive.Windows.Threading.dll</HintPath>
129129
</Reference>
130+
<Reference Include="System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
131+
<HintPath>..\packages\System.ValueTuple.4.4.0\lib\netstandard1.0\System.ValueTuple.dll</HintPath>
132+
</Reference>
130133
<Reference Include="System.Windows" />
131134
<Reference Include="System.Windows.Presentation" />
132135
<Reference Include="System.Xaml" />

‎ReactWindows/ReactNative.Net46.Tests/packages.config

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
33
<package id="Facebook.Yoga" version="1.5.0-pre1" targetFramework="net46" />
44
<package id="Newtonsoft.Json" version="10.0.3" targetFramework="net46" />
@@ -14,5 +14,6 @@
1414
<package id="System.Reactive.Linq" version="4.0.0-preview00001" targetFramework="net46" />
1515
<package id="System.Reactive.PlatformServices" version="4.0.0-preview00001" targetFramework="net46" />
1616
<package id="System.Reactive.Windows.Threading" version="4.0.0-preview00001" targetFramework="net46" />
17+
<package id="System.ValueTuple" version="4.4.0" targetFramework="net46" />
1718
<package id="WindowsBase" version="4.6.1055.0" targetFramework="net46" />
1819
</packages>

0 commit comments

Comments
 (0)