fix(NetworkModule) - form-data fixes based upon comments

mattpodwysocki · mattpodwysocki · commit d57e21712570 · 2016-05-19T16:44:44.000-04:00
diff --git a/ReactWindows/ReactNative/Modules/Network/NetworkingModule.cs b/ReactWindows/ReactNative/Modules/Network/NetworkingModule.cs
@@ -117,7 +117,13 @@ public void sendRequest(
                 }
                 else if ((uri = data.Value<string>("uri")) != null)
                 {
-                    throw new NotImplementedException("HTTP handling for file payloads not yet implemented.");
+                    if (headerData.ContentType == null)
+                    {
+                        OnRequestError(requestId, "Payload is set but no 'content-type' header specified.", false);
+                        return;
+                    }
+
+                    throw new NotImplementedException("URI upload is not supported");
                 }
                 else if ((formData = data.Value<JArray>("formData")) != null)
                 {
@@ -131,8 +137,6 @@ public void sendRequest(
                     {
                         var fieldName = content.Value<string>("fieldName");
 
-                        var formDataHeaders = content.Value<JArray>("headers");
-
                         var stringContent = content.Value<string>("string");
                         if (stringContent != null)
                         {
@@ -141,8 +145,6 @@ public void sendRequest(
                     }
 
                     request.Content = formDataContent;
-                    // TODO: Check for gzipped body content
-                    // TODO: Issue #383
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,13 @@ public void sendRequest(`
`117`	`117`	`}`
`118`	`118`	`else if ((uri = data.Value<string>("uri")) != null)`
`119`	`119`	`{`
`120`		`- throw new NotImplementedException("HTTP handling for file payloads not yet implemented.");`
	`120`	`+ if (headerData.ContentType == null)`
	`121`	`+ {`
	`122`	`+ OnRequestError(requestId, "Payload is set but no 'content-type' header specified.", false);`
	`123`	`+ return;`
	`124`	`+ }`
	`125`	`+`
	`126`	`+ throw new NotImplementedException("URI upload is not supported");`
`121`	`127`	`}`
`122`	`128`	`else if ((formData = data.Value<JArray>("formData")) != null)`
`123`	`129`	`{`
`@@ -131,8 +137,6 @@ public void sendRequest(`
`131`	`137`	`{`
`132`	`138`	`var fieldName = content.Value<string>("fieldName");`
`133`	`139`
`134`		`- var formDataHeaders = content.Value<JArray>("headers");`
`135`		`-`
`136`	`140`	`var stringContent = content.Value<string>("string");`
`137`	`141`	`if (stringContent != null)`
`138`	`142`	`{`
`@@ -141,8 +145,6 @@ public void sendRequest(`
`141`	`145`	`}`
`142`	`146`
`143`	`147`	`request.Content = formDataContent;`
`144`		`- // TODO: Check for gzipped body content`
`145`		`- // TODO: Issue #383`
`146`	`148`	`}`
`147`	`149`	`}`
`148`	`150`