Add null check to deal with the usage of { stdio: 'inherit' }. (microsoft#1825)

exKAZUu · rozele · commit f807db770c2a · 2018-05-18T10:04:30.000-04:00
diff --git a/local-cli/runWpf/utils/msbuildtools.js b/local-cli/runWpf/utils/msbuildtools.js
@@ -57,8 +57,11 @@ class MSBuildTools {
 
     const cmd = `"${path.join(this.path, 'msbuild.exe')}" ` + ['"' + slnFile + '"'].concat(args).join(' ');
     const execOptions = verbose ? { stdio: 'inherit' } : {};
-    const results = child_process.execSync(cmd, execOptions).toString().split(EOL);
-    results.forEach(result => console.log(chalk.white(result)));
+    const result = child_process.execSync(cmd, execOptions);
+    // result is null when enabling verbose option
+    if (result != null) {
+      result.toString().split(EOL).forEach(result => console.log(chalk.white(result)));
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,11 @@ class MSBuildTools {`
`57`	`57`
`58`	`58`	const cmd = `"${path.join(this.path, 'msbuild.exe')}" ` + ['"' + slnFile + '"'].concat(args).join(' ');
`59`	`59`	`const execOptions = verbose ? { stdio: 'inherit' } : {};`
`60`		`- const results = child_process.execSync(cmd, execOptions).toString().split(EOL);`
`61`		`- results.forEach(result => console.log(chalk.white(result)));`
	`60`	`+ const result = child_process.execSync(cmd, execOptions);`
	`61`	`+ // result is null when enabling verbose option`
	`62`	`+ if (result != null) {`
	`63`	`+ result.toString().split(EOL).forEach(result => console.log(chalk.white(result)));`
	`64`	`+ }`
`62`	`65`	`}`
`63`	`66`	`}`
`64`	`67`