fix(WebView): Fix bug with onLoadingStart event (microsoft#1495)

rozele · web-flow · commit fe21397c85a2 · 2017-11-06T19:26:53.000-05:00
Mistakenly set DOM load starting event to `topLoadStart` instead of `topLoadingStart`. The direct events for `WebView` are mapped in the UIManager; the `topLoadStart` event is not mapped for the `WebView` whereas the latter is.
diff --git a/ReactWindows/ReactNative/Views/Web/Events/WebViewLoadEvent.cs b/ReactWindows/ReactNative/Views/Web/Events/WebViewLoadEvent.cs
@@ -1,11 +1,11 @@
-﻿using Newtonsoft.Json.Linq;
+using Newtonsoft.Json.Linq;
 using ReactNative.UIManager.Events;
 
 namespace ReactNative.Views.Web.Events
 {
     class WebViewLoadEvent : Event
     {
-        public const string TopLoadStart = "topLoadStart";
+        public const string TopLoadingStart = "topLoadingStart";
         public const string TopLoadingFinish = "topLoadingFinish";
 
         private readonly string _url;
diff --git a/ReactWindows/ReactNative/Views/Web/ReactWebViewManager.cs b/ReactWindows/ReactNative/Views/Web/ReactWebViewManager.cs
@@ -347,7 +347,7 @@ private void OnNavigationStarting(object sender, WebViewNavigationStartingEventA
                 .DispatchEvent(
                     new WebViewLoadEvent(
                          tag,
-                         WebViewLoadEvent.TopLoadStart,
+                         WebViewLoadEvent.TopLoadingStart,
                          e.Uri?.ToString(),
                          true,
                          webView.DocumentTitle,

Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`		`-using Newtonsoft.Json.Linq;`
	`1`	`+using Newtonsoft.Json.Linq;`
`2`	`2`	`using ReactNative.UIManager.Events;`
`3`	`3`
`4`	`4`	`namespace ReactNative.Views.Web.Events`
`5`	`5`	`{`
`6`	`6`	`class WebViewLoadEvent : Event`
`7`	`7`	`{`
`8`		`- public const string TopLoadStart = "topLoadStart";`
	`8`	`+ public const string TopLoadingStart = "topLoadingStart";`
`9`	`9`	`public const string TopLoadingFinish = "topLoadingFinish";`
`10`	`10`
`11`	`11`	`private readonly string _url;`