Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nextmv-io/nextplot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.2
Choose a base ref
...
head repository: nextmv-io/nextplot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.3
Choose a head ref
  • 5 commits
  • 3 files changed
  • 3 contributors

Commits on Feb 12, 2024

  1. Copy the full SHA
    b792070 View commit details
  2. Bump version

    merschformann committed Feb 12, 2024
    Copy the full SHA
    fef6433 View commit details
  3. Merge pull request #2 from nextmv-io/merschformann/improve-error-mess…

    …ages
    
    Improves data handling
    merschformann authored Feb 12, 2024
    Copy the full SHA
    a7c3efe View commit details
  4. Copy the full SHA
    8869be6 View commit details
  5. Bump version to v0.1.3

    nextmv-bot committed Feb 12, 2024
    Copy the full SHA
    e5e4fd6 View commit details
Showing with 11 additions and 2 deletions.
  1. +1 −0 .gitignore
  2. +1 −1 nextplot/__about__.py
  3. +9 −1 nextplot/common.py
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -142,3 +142,4 @@ tmp/
*.pbf
*.ch
build/
*.json
2 changes: 1 addition & 1 deletion nextplot/__about__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "v0.1.2"
__version__ = "v0.1.3"
10 changes: 9 additions & 1 deletion nextplot/common.py
Original file line number Diff line number Diff line change
@@ -148,7 +148,11 @@ def extract_position(value, jpath_x="", jpath_y="") -> types.Position:
else:
return types.Position(float(value[0]), float(value[1]), desc)
except Exception:
print("error parsing point," + " is the given JSON path pointing to the correct data?")
print(
f"error parsing point using {jpath_x} and {jpath_y}, "
+ "please make sure the paths point to valid numbers x/y. point data:"
)
print(desc)
raise


@@ -195,6 +199,10 @@ def extract_position_groups(
# Extract all groups
groups, oob_indices = [], []
for match in group_expression.find(group_data):
# If the value is null, we skip it (with a warning)
if match.value is None:
print(f"Warning! Found 'null' value at {str(match.full_path)}, skipping...")
continue
# If no separate position file was given, we expect positions to be given
group = []
if len(positions) == 0: