KafkaClient: log responses by requestId for debugging

Dana Powers · Dana Powers · commit d6585483e085 · 2015-06-09T21:57:26.000-07:00
diff --git a/kafka/client.py b/kafka/client.py
@@ -189,10 +189,12 @@ def _send_broker_aware_request(self, payloads, encoder_fn, decoder_fn):
             # No exception, try to get response
             else:
 
-                # decoder_fn=None signal that the server  is expected to not
+                # decoder_fn=None signal that the server is expected to not
                 # send a response.  This probably only applies to
                 # ProduceRequest w/ acks = 0
                 if decoder_fn is None:
+                    log.debug('Request %s does not expect a response '
+                              '(skipping conn.recv)', requestId)
                     for payload in payloads:
                         responses_by_broker[broker].append(None)
                     continue
@@ -211,6 +213,7 @@ def _send_broker_aware_request(self, payloads, encoder_fn, decoder_fn):
                 else:
                     for payload_response in decoder_fn(response):
                         responses_by_broker[broker].append(payload_response)
+                    log.debug('Response %s: %s', requestId, responses_by_broker[broker])
 
         # Connection errors generally mean stale metadata
         # although sometimes it means incorrect api request
