Apply ruff/flake8-simplify rule SIM103

DimitriPapadopoulos · DimitriPapadopoulos · commit b84d9bcef8e0 · 2024-10-05T18:19:38.000+02:00
SIM103 Return the (negated) condition directly
diff --git a/nipy/algorithms/registration/optimizer.py b/nipy/algorithms/registration/optimizer.py
@@ -46,7 +46,4 @@ def configure_optimizer(optimizer, fprime=None, fhess=None, **kwargs):
 
 
 def use_derivatives(optimizer):
-    if optimizer in ('simplex', 'powell'):
-        return False
-    else:
-        return True
+    return optimizer not in ('simplex', 'powell')
diff --git a/nipy/algorithms/statistics/models/regression.py b/nipy/algorithms/statistics/models/regression.py
@@ -264,9 +264,7 @@ def has_intercept(self):
         o = np.ones(self.design.shape[0])
         obeta = np.dot(self.calc_beta, o)
         ohat = np.dot(self.wdesign, obeta)
-        if np.allclose(ohat, o):
-            return True
-        return False
+        return np.allclose(ohat, o)
 
     @cached_property
     def rank(self):
@@ -872,6 +870,4 @@ def isestimable(C, D):
     if C.shape[1] != D.shape[1]:
         raise ValueError('Contrast should have %d columns' % D.shape[1])
     new = np.vstack([C, D])
-    if matrix_rank(new) != matrix_rank(D):
-        return False
-    return True
+    return matrix_rank(new) == matrix_rank(D)
