Consider what to do about fmri/spm code #166
Comments
|
if code is lying around and not being used anywhere else in the library and is not part of the api, remove it (this is git - you can always get back to it if needed). also given that the most useful aspect here is reml, that should be moved to a more aptly named place - reml is an algorithm and has nothing to do with spm per se except they use it. it should really be part of scipy or statsmodels. |
|
+1 for moving ReML, and removing the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bertrand noticed that the code in
nipy/modalities/fmri/spmhad no tests and suggested it could be deleted:#157
However, there appears to be some useful code in there. In particular it may be useful to compare other algorithms to SPM, and JB tells me the ReML algorithm is pleasantly easy to follow.
We should review this code, at very least add tests, consider removing code that won't be used, and perhaps refactor the rest into other places in the codebase.
The text was updated successfully, but these errors were encountered: