Skip to content

MAINT: Add github action to trigger tutorials for release branches #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2022
Merged

MAINT: Add github action to trigger tutorials for release branches #3504

merged 1 commit into from
Sep 20, 2022

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Sep 2, 2022 •
edited
Loading

This is an effort to remove a manual step in the release process.

Currently, we are submitting a PR to the tutorials repo to build from the current release branch.

This proposes a new action that runs whenever an upstream rel/* branch is pushed to that:

  1. Triggers a "manual" dispatch to the tutorial's action
  2. Tracks the status of the job until it i) succeeds, ii) fails, or iii) hits the timeout (currently 1 hour)

For this to work, it will require (cc @djarecka who may have the proper permissions):

  1. ENH: Allow GH Action to run with manual trigger miykael/nipype_tutorial#180 to be merged in
  2. A PAT for the nipype_tutorial repo to be created and added to this organization's secrets as TUTORIAL_ACCESS_TOKEN

@codecov
Copy link

codecov bot commented Sep 2, 2022 •
edited
Loading

Codecov Report

Merging #3504 (2b15c0b) into master (71411b0) will decrease coverage by 1.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3504      +/-   ##
==========================================
- Coverage   65.25%   63.63%   -1.63%     
==========================================
  Files         309      309              
  Lines       40859    40859              
  Branches     5379     5379              
==========================================
- Hits        26663    25999     -664     
- Misses      13126    13835     +709     
+ Partials     1070     1025      -45
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/testing/fixtures.py 57.14% <0.00%> (-41.56%) ⬇️
nipype/interfaces/freesurfer/base.py 48.38% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/interfaces/fsl/maths.py 79.06% <0.00%> (-19.19%) ⬇️
nipype/interfaces/dcm2nii.py 50.00% <0.00%> (-15.28%) ⬇️
nipype/interfaces/fsl/base.py 67.02% <0.00%> (-13.83%) ⬇️
nipype/interfaces/fsl/preprocess.py 61.04% <0.00%> (-10.50%) ⬇️
nipype/interfaces/spm/base.py 60.06% <0.00%> (-7.60%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@effigies
Copy link
Member

@mgxd @djarecka Is this something that should go in soon? I was thinking of dropping a bugfix release, and I'm game to try it out if this can go in quickly.

@mgxd
Copy link
Member Author

mgxd commented Sep 20, 2022

We need to create/add a PAT (repo scoped) and assign it as TUTORIAL_ACCESS_TOKEN. However, that user has to have admin access on the tutorials - which I think is limited to dorota or miykael. Maybe we could add @nipybot as an admin?

@djarecka
Copy link
Collaborator

unfortunately I don't have admin access to the tutorial... I have write access and can merge your PRs, but I don't have access to the settings :(

@mgxd
Copy link
Member Author

mgxd commented Sep 20, 2022

Sorry, I think I misspoke. I believe if you can trigger the workflow here (https://github.com/miykael/nipype_tutorial/actions) then you have sufficient permissions

@djarecka
Copy link
Collaborator

yes, I can rerun jobs and I have access to New workflow. Do you have some instruction that I can follow to set it? Or perhaps we can have a quick call and do it together?

@mgxd mgxd marked this pull request as ready for review September 20, 2022 20:56
@djarecka djarecka merged commit e5be008 into nipy:master Sep 20, 2022
@mgxd mgxd deleted the maint/tutorial-trigger branch September 20, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgxd @effigies @djarecka