Use out_prefix instead of "w" in spm.Normalize12 #3600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this PR that will be fast to review:
I think there are two solutions.
1- Remove the
out_prefix
parameter and the prefix remains always at "w"or
2- use the
out_prefix
parameter instead of the hard-coded "w" value.I think the second solution is the right one.
I propose a slight modification to this effect.