Fix compare() for subset check (S.A ⊆ T.A) (TheAlgorithms#4978)

itakurah · web-flow · commit 92131de3774d · 2023-12-07T18:06:56.000+02:00
diff --git a/src/main/java/com/thealgorithms/datastructures/crdt/GSet.java b/src/main/java/com/thealgorithms/datastructures/crdt/GSet.java
@@ -50,7 +50,7 @@ public boolean lookup(T e) {
      * @return true if the current G-Set is a subset of the other, false otherwise
      */
     public boolean compare(GSet<T> other) {
-        return elements.containsAll(other.elements);
+        return other.elements.containsAll(elements);
     }
 
     /**
diff --git a/src/test/java/com/thealgorithms/datastructures/crdt/GSetTest.java b/src/test/java/com/thealgorithms/datastructures/crdt/GSetTest.java
@@ -32,20 +32,14 @@ void testLookup() {
     void testCompare() {
         GSet<String> gSet1 = new GSet<>();
         GSet<String> gSet2 = new GSet<>();
-
         gSet1.addElement("apple");
         gSet1.addElement("orange");
-
         gSet2.addElement("orange");
-        gSet2.addElement("banana");
-
         assertFalse(gSet1.compare(gSet2));
-
-        GSet<String> gSet3 = new GSet<>();
-        gSet3.addElement("apple");
-        gSet3.addElement("orange");
-
-        assertTrue(gSet1.compare(gSet3));
+        gSet2.addElement("apple");
+        assertTrue(gSet1.compare(gSet2));
+        gSet2.addElement("banana");
+        assertTrue(gSet1.compare(gSet2));
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public boolean lookup(T e) {`
`50`	`50`	`* @return true if the current G-Set is a subset of the other, false otherwise`
`51`	`51`	`*/`
`52`	`52`	`public boolean compare(GSet<T> other) {`
`53`		`- return elements.containsAll(other.elements);`
	`53`	`+ return other.elements.containsAll(elements);`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`/**`