tools: restrict internal code from using public url module

LiviaMedeiros · ruyadorno · commit 08ffc6344c10 · 2023-09-27T22:32:48.000-04:00
PR-URL: #49590 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -175,6 +175,10 @@ rules:
       message: Use `const { structuredClone } = require('internal/structured_clone');` instead of the global.
     - name: SubtleCrypto
       message: Use `const { SubtleCrypto } = require('internal/crypto/webcrypto');` instead of the global.
+  no-restricted-modules:
+    - error
+    - name: url
+      message: Require `internal/url` instead of `url`.
   # Custom rules in tools/eslint-rules
   node-core/avoid-prototype-pollution: error
   node-core/lowercase-name-for-primitive: error
diff --git a/lib/internal/bootstrap/switches/is_main_thread.js b/lib/internal/bootstrap/switches/is_main_thread.js
@@ -290,7 +290,7 @@ rawMethods.resetStdioForTesting = function() {
 // Needed by the module loader and generally needed everywhere.
 require('fs');
 require('util');
-require('url');
+require('url'); // eslint-disable-line no-restricted-modules
 
 require('internal/modules/cjs/loader');
 require('internal/modules/esm/utils');
