deps: always define V8_EXPORT_PRIVATE as no-op

targos · targos · commit 1142f78f1df5 · 2025-01-31T12:46:08.000+01:00
dllexport introduces issues when compiling with MSVC. PR-URL: #47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #55014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/common.gypi b/common.gypi
@@ -37,7 +37,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.0',
+    'v8_embedder_string': '-node.1',
 
     ##### V8 defaults for Node.js #####
 
diff --git a/deps/v8/src/base/macros.h b/deps/v8/src/base/macros.h
@@ -423,9 +423,9 @@ bool is_inbounds(float_t v) {
 // Setup for Windows shared library export.
 #define V8_EXPORT_ENUM
 #ifdef BUILDING_V8_SHARED_PRIVATE
-#define V8_EXPORT_PRIVATE __declspec(dllexport)
+#define V8_EXPORT_PRIVATE
 #elif USING_V8_SHARED_PRIVATE
-#define V8_EXPORT_PRIVATE __declspec(dllimport)
+#define V8_EXPORT_PRIVATE
 #else
 #define V8_EXPORT_PRIVATE
 #endif  // BUILDING_V8_SHARED
@@ -435,8 +435,8 @@ bool is_inbounds(float_t v) {
 // Setup for Linux shared library export.
 #if V8_HAS_ATTRIBUTE_VISIBILITY
 #ifdef BUILDING_V8_SHARED_PRIVATE
-#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
-#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
+#define V8_EXPORT_PRIVATE
+#define V8_EXPORT_ENUM
 #else
 #define V8_EXPORT_PRIVATE
 #define V8_EXPORT_ENUM
