src: cache urlpattern properties

JonasBa · aduh95 · commit 3ddc5cd87555 · 2025-03-23T11:07:43.000+01:00
PR-URL: #57465 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/src/node_url_pattern.cc b/src/node_url_pattern.cc
@@ -168,6 +168,10 @@ URLPattern::URLPattern(Environment* env,
 
 void URLPattern::MemoryInfo(MemoryTracker* tracker) const {
   tracker->TraitTrackInline(url_pattern_, "url_pattern");
+#define URL_PATTERN_CACHED_VALUES(_, lowercase)                                \
+  tracker->TrackField(#lowercase, lowercase);
+  URL_PATTERN_COMPONENTS(URL_PATTERN_CACHED_VALUES)
+#undef URL_PATTERN_CACHED_VALUES
 }
 
 void URLPattern::New(const FunctionCallbackInfo<Value>& args) {
@@ -466,10 +470,20 @@ URLPattern::URLPatternOptions::FromJsObject(Environment* env,
   return options;
 }
 
+// Perform value lookup and cache the result in a v8::Global.
 #define URL_PATTERN_COMPONENT_GETTERS(uppercase_name, lowercase_name)          \
-  MaybeLocal<Value> URLPattern::uppercase_name() const {                       \
-    auto context = env()->context();                                           \
-    return ToV8Value(context, url_pattern_.get_##lowercase_name());            \
+  MaybeLocal<Value> URLPattern::uppercase_name() {                             \
+    auto isolate = env()->isolate();                                           \
+    if (lowercase_name.IsEmpty()) {                                            \
+      Local<Value> value;                                                      \
+      if (ToV8Value(env()->context(), url_pattern_.get_##lowercase_name())     \
+              .ToLocal(&value)) {                                              \
+        lowercase_name.Reset(isolate, value);                                  \
+        return value;                                                          \
+      }                                                                        \
+      return {};                                                               \
+    }                                                                          \
+    return lowercase_name.Get(isolate);                                        \
   }
 URL_PATTERN_COMPONENTS(URL_PATTERN_COMPONENT_GETTERS)
 #undef URL_PATTERN_COMPONENT_GETTERS
diff --git a/src/node_url_pattern.h b/src/node_url_pattern.h
@@ -93,8 +93,7 @@ class URLPattern : public BaseObject {
  private:
   ada::url_pattern<URLPatternRegexProvider> url_pattern_;
   // Getter methods
-#define URL_PATTERN_COMPONENT_GETTERS(name, _)                                 \
-  v8::MaybeLocal<v8::Value> name() const;
+#define URL_PATTERN_COMPONENT_GETTERS(name, _) v8::MaybeLocal<v8::Value> name();
   URL_PATTERN_COMPONENTS(URL_PATTERN_COMPONENT_GETTERS)
 #undef URL_PATTERN_COMPONENT_GETTERS
   bool HasRegExpGroups() const;
@@ -107,6 +106,10 @@ class URLPattern : public BaseObject {
       Environment* env,
       const ada::url_pattern_input& input,
       std::optional<std::string_view>& baseURL);  // NOLINT (runtime/references)
+
+#define URL_PATTERN_CACHED_VALUES(_, name) v8::Global<v8::Value> name;
+  URL_PATTERN_COMPONENTS(URL_PATTERN_CACHED_VALUES)
+#undef URL_PATTERN_CACHED_VALUES
 };
 
 }  // namespace node::url_pattern
