crypto: change assertion to condition in bio

indutny · indutny · commit bf8dc0762a36 · 2013-06-19T22:03:07.000+02:00
Read head can be the same as write head, even if there's some data to
read.
diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc
@@ -209,8 +209,7 @@ size_t NodeBIO::Read(char* out, size_t size) {
       read_head_->write_pos_ = 0;
 
       // But not get beyond write_head_
-      if (length_ != bytes_read) {
-        assert(read_head_ != write_head_);
+      if (length_ != bytes_read && read_head_ != write_head_) {
         read_head_ = read_head_->next_;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -209,8 +209,7 @@ size_t NodeBIO::Read(char* out, size_t size) {`
`209`	`209`	`read_head_->write_pos_ = 0;`
`210`	`210`
`211`	`211`	`// But not get beyond write_head_`
`212`		`- if (length_ != bytes_read) {`
`213`		`- assert(read_head_ != write_head_);`
	`212`	`+ if (length_ != bytes_read && read_head_ != write_head_) {`
`214`	`213`	`read_head_ = read_head_->next_;`
`215`	`214`	`}`
`216`	`215`	`}`