tools: do not pass invalid flag to C compiler

targos · targos · commit e88a301e989c · 2024-02-15T12:05:41.000+01:00
`-Wno-invalid-offsetof` is only valid for C++ and GCC warns about its usage for C. PR-URL: #51409 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -1989,6 +1989,12 @@
           ]
         }],
       ],
+      # -Wno-invalid-offsetof flag is not valid for C.
+      # The flag is initially set in `toolchain.gypi` for all targets.
+      'cflags!': [ '-Wno-invalid-offsetof' ],
+      'xcode_settings': {
+        'WARNING_CFLAGS!': ['-Wno-invalid-offsetof']
+      },
       'direct_dependent_settings': {
         'include_dirs': [
           '<(V8_ROOT)/third_party/zlib',
