src: add a method to get string encoding info #56147

theweipeng · 2024-12-05T16:31:30Z

util: Add a method to get the encoding information of a string.

Currently, we should check the encoding of the string before we use buffer.write("string", 'latin1') and buffer.write("string", 'utf16le') to write to the buffer.
This PR adds a method to return the encoding information from V8.

Closes: #56090

codecov · 2024-12-05T22:42:14Z

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (3c2da4b) to head (bd086ce).
Report is 592 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_v8.cc	81.25%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56147      +/-   ##
==========================================
+ Coverage   87.99%   88.54%   +0.55%     
==========================================
  Files         656      657       +1     
  Lines      188999   190794    +1795     
  Branches    35981    36611     +630     
==========================================
+ Hits       166301   168933    +2632     
+ Misses      15865    15044     -821     
+ Partials     6833     6817      -16

Files with missing lines	Coverage Δ
lib/v8.js	`99.34% <100.00%> (+0.70%)`	⬆️
src/node_external_reference.h	`100.00% <ø> (ø)`
src/node_v8.cc	`90.67% <81.25%> (-0.52%)`	⬇️

... and 138 files with indirect coverage changes

theweipeng · 2024-12-17T07:27:56Z

I've been waiting for some feedback on this PR, could someone take a look at this ? I'd appreciate any feedback you can provide. Thanks! @nodejs-github-bot

nodejs-github-bot · 2024-12-17T10:21:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64079/

addaleax

If you want to add an API like this, keep in mind that this

does not return any information about the string itself, which does not have an encoding per se, only its underlying representation in the JS engine
does not provide reliable output

You'll probably want to rename it and modify the documentation as needed.

It's hard to see an actual use case for this API, though. Getting this information can be useful when dealing with JS strings in C++, but there this information is already directly available.

addaleax · 2024-12-17T20:01:19Z

Actually, I see that @joyeecheung already left a number of helpful comments on the original ticket. Moving this to the v8 API makes a bit more sense, because it really is engine-specific, and she suggests a better name for it that reflects the subtleties involved here (isOneByteRepresentation), plus points out that utf16le isn't accurate because we'd need to take platform endianness into account.

So – Joyee made a lot of good suggestions here already, and you'll probably just want to incorporate them.

theweipeng · 2024-12-18T02:51:53Z

Actually, I see that @joyeecheung already left a number of helpful comments on the original ticket. Moving this to the v8 API makes a bit more sense, because it really is engine-specific, and she suggests a better name for it that reflects the subtleties involved here (isOneByteRepresentation), plus points out that utf16le isn't accurate because we'd need to take platform endianness into account.

So – Joyee made a lot of good suggestions here already, and you'll probably just want to incorporate them.

Understood, I'll correct the API placement. Thanks for pointing it out.

addaleax

Removing the 'changes requested' marker but this should have better documentation and, ideally, a use case that explains why we're adding this to the API

doc/api/v8.md

outdated

theweipeng · 2024-12-26T06:59:14Z

Removing the 'changes requested' marker but this should have better documentation and, ideally, a use case that explains why we're adding this to the API

Could you please review the document changes and trigger the code CI?

nodejs-github-bot · 2024-12-26T16:53:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64224/

theweipeng · 2024-12-27T01:48:01Z

Looks like a flaky test. Needs a re-run I think. @nodejs-github-bot

nodejs-github-bot · 2024-12-27T03:21:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64228/

test/parallel/test-v8-string-is-one-byte-representation.js

nodejs-github-bot · 2025-01-03T17:38:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64311/

addaleax · 2025-01-03T20:42:32Z

@theweipeng I was comparing the current version against always using UTF16-LE, to be clear, not against UTF-8. Otherwise I don't think you end up with a fair comparison (UTF-8 mainly has space saving advantages, but this seems to be about runtime performance instead).

theweipeng · 2025-01-04T02:33:54Z

@theweipeng I was comparing the current version against always using UTF16-LE, to be clear, not against UTF-8. Otherwise I don't think you end up with a fair comparison (UTF-8 mainly has space saving advantages, but this seems to be about runtime performance instead).

@addaleax

I compared the current version against always uses UTF-16LE, and there is still a noticeable improvement when the string is in Latin1. I think this imporvement comes from encoding Latin1 to utf16

My machine: Apple M2 Pro 16GB

Here is my code:

const { isStringOneByteRepresentation } = require("v8");

const bf = Buffer.alloc(1000);

function benchmark(input, topic) {
    console.time("before " + topic);
    for (let index = 0; index < 999999; index++) {
        bf.writeUint32LE(0, input.length * 2);
        bf.write(input, 4, 'utf16le');
    }
    console.timeEnd("before " + topic);
    
    console.time("after " + topic);
    for (let index = 0; index < 999999; index++) {
        if (isStringOneByteRepresentation(input)) {
            bf.writeUint32LE(0, input.length);
            bf.write(input, 4, 'latin1');
        } else {
            bf.writeUint32LE(0, input.length * 2);
            bf.write(input, 4, 'utf16le');
        }
    }
    console.timeEnd("after " + topic);
    console.log("\n");
}

benchmark(new Array(1).fill(0).map(x => "qwertyuiopasdfghjklzxcvbnm").join(''), "short latin1");
benchmark(new Array(1).fill(0).map(x => "😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁").join(''), "short utf16")


benchmark(new Array(5).fill(0).map(x => "qwertyuiopasdfghjklzxcvbnm").join(''), "long latin1");
benchmark(new Array(5).fill(0).map(x => "😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁").join(''), "long utf16")

Here are the results:

before short latin1: 73.69ms
after short latin1: 22.572ms


before short utf16: 60.322ms
after short utf16: 57.602ms


before long latin1: 62.184ms
after long latin1: 25.765ms


before long utf16: 61.797ms
after long utf16: 56.201ms

theweipeng · 2025-01-16T07:03:07Z

@theweipeng I was comparing the current version against always using UTF16-LE, to be clear, not against UTF-8. Otherwise I don't think you end up with a fair comparison (UTF-8 mainly has space saving advantages, but this seems to be about runtime performance instead).

@addaleax

I compared the current version against always uses UTF-16LE, and there is still a noticeable improvement when the string is in Latin1. I think this imporvement comes from encoding Latin1 to utf16

My machine: Apple M2 Pro 16GB

Here is my code:

const { isStringOneByteRepresentation } = require("v8");

const bf = Buffer.alloc(1000);

function benchmark(input, topic) {
    console.time("before " + topic);
    for (let index = 0; index < 999999; index++) {
        bf.writeUint32LE(0, input.length * 2);
        bf.write(input, 4, 'utf16le');
    }
    console.timeEnd("before " + topic);
    
    console.time("after " + topic);
    for (let index = 0; index < 999999; index++) {
        if (isStringOneByteRepresentation(input)) {
            bf.writeUint32LE(0, input.length);
            bf.write(input, 4, 'latin1');
        } else {
            bf.writeUint32LE(0, input.length * 2);
            bf.write(input, 4, 'utf16le');
        }
    }
    console.timeEnd("after " + topic);
    console.log("\n");
}

benchmark(new Array(1).fill(0).map(x => "qwertyuiopasdfghjklzxcvbnm").join(''), "short latin1");
benchmark(new Array(1).fill(0).map(x => "😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁").join(''), "short utf16")


benchmark(new Array(5).fill(0).map(x => "qwertyuiopasdfghjklzxcvbnm").join(''), "long latin1");
benchmark(new Array(5).fill(0).map(x => "😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁😁").join(''), "long utf16")

Here are the results:

before short latin1: 73.69ms
after short latin1: 22.572ms


before short utf16: 60.322ms
after short utf16: 57.602ms


before long latin1: 62.184ms
after long latin1: 25.765ms


before long utf16: 61.797ms
after long utf16: 56.201ms

@addaleax My benchmark results are quite good. Could you please help check them?

nodejs-github-bot · 2025-02-21T20:24:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65366/ 💚

theweipeng · 2025-02-24T09:53:41Z

If there’s anything else I can do to help move this forward, please let me know. I’m more than happy to make any additional changes or provide further details.

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

jasnell · 2025-02-25T16:01:56Z

Landed in 6cb0690

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `23.9.0` -> `23.10.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v23.10.0`](https://github.com/nodejs/node/releases/tag/v23.10.0): 2025-03-13, Version 23.10.0 (Current), @aduh95 [Compare Source](nodejs/node@v23.9.0...v23.10.0) ##### Notable Changes ##### Introducing `--experimental-config-file` With the introduction of test runner, SEA, and other feature that require a lot of flags, a JSON config flag would improve by a lot the developer experience and increase adoption. You can have a `node.config.json` containing: ```json { "$schema": "https://nodejs.org/dist/v23.10.0/docs/node-config-schema.json", "nodeOptions": { "test-coverage-lines": 80, "test-coverage-branches": 60 } } ``` You can run your tests without passing the flags defined in the config file. ```bash node --experimental-default-config-file --test --experimental-test-coverage ``` or ```bash node --experimental-config-file=node.config.json --test --experimental-test-coverage ``` Node.js will not sanitize or perform validation on the user-provided configuration, so only ever use trusted configuration files. Contributed by Marco Ippolito in [#57016](nodejs/node#57016) and [#57171](nodejs/node#57171). ##### Other Notable Changes - \[[`323e3ac93c`](nodejs/node@323e3ac93c)] - **crypto**: update root certificates to NSS 3.108 (Node.js GitHub Bot) [#57381](nodejs/node#57381) - \[[`6fd2ec6816`](nodejs/node@6fd2ec6816)] - **doc**: add `@geeksilva97` to collaborators (Edy Silva) [#57241](nodejs/node#57241) - \[[`d8937f1742`](nodejs/node@d8937f1742)] - **(SEMVER-MINOR)** **src**: create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) [#57016](nodejs/node#57016) - \[[`5054fc7941`](nodejs/node@5054fc7941)] - **(SEMVER-MINOR)** **test_runner**: change ts default glob (Marco Ippolito) [#57359](nodejs/node#57359) - \[[`75f11ae1cc`](nodejs/node@75f11ae1cc)] - **(SEMVER-MINOR)** **tls**: implement `tls.getCACertificates()` (Joyee Cheung) [#57107](nodejs/node#57107) - \[[`a22c21ceb8`](nodejs/node@a22c21ceb8)] - **(SEMVER-MINOR)** **v8**: add `v8.getCppHeapStatistics()` method (Aditi) [#57146](nodejs/node#57146) ##### Commits - \[[`2daee76b26`](nodejs/node@2daee76b26)] - **assert**: improve myers diff performance (Giovanni Bucci) [#57279](nodejs/node#57279) - \[[`2fbd3bbea7`](nodejs/node@2fbd3bbea7)] - **build**: fix compatibility with V8's `depot_tools` (Richard Lau) [#57330](nodejs/node#57330) - \[[`6a2e4c5fc1`](nodejs/node@6a2e4c5fc1)] - **build,win**: disable node pch with ccache (Stefan Stojanovic) [#57224](nodejs/node#57224) - \[[`323e3ac93c`](nodejs/node@323e3ac93c)] - **crypto**: update root certificates to NSS 3.108 (Node.js GitHub Bot) [#57381](nodejs/node#57381) - \[[`906f23d0e7`](nodejs/node@906f23d0e7)] - **crypto**: add support for intermediate certs in --use-system-ca (Tim Jacomb) [#57164](nodejs/node#57164) - \[[`03cd7920c8`](nodejs/node@03cd7920c8)] - **deps**: update simdjson to 3.12.2 (Node.js GitHub Bot) [#57084](nodejs/node#57084) - \[[`9e1fce9a5c`](nodejs/node@9e1fce9a5c)] - **deps**: update archs files for openssl-3.0.16 (Node.js GitHub Bot) [#57335](nodejs/node#57335) - \[[`4056c1f83e`](nodejs/node@4056c1f83e)] - **deps**: upgrade openssl sources to quictls/openssl-3.0.16 (Node.js GitHub Bot) [#57335](nodejs/node#57335) - \[[`b402799070`](nodejs/node@b402799070)] - **deps**: update corepack to 0.32.0 (Node.js GitHub Bot) [#57265](nodejs/node#57265) - \[[`ce1cfff79a`](nodejs/node@ce1cfff79a)] - **deps**: update amaro to 0.4.1 (marco-ippolito) [#57121](nodejs/node#57121) - \[[`0ac977d679`](nodejs/node@0ac977d679)] - **deps**: update gyp file for ngtcp2 1.11.0 (Richard Lau) [#57225](nodejs/node#57225) - \[[`f34d78df1f`](nodejs/node@f34d78df1f)] - **deps**: update ada to 3.1.3 (Node.js GitHub Bot) [#57222](nodejs/node#57222) - \[[`4fe9916701`](nodejs/node@4fe9916701)] - **dns**: remove redundant code using common variable (Deokjin Kim) [#57386](nodejs/node#57386) - \[[`1c271b162b`](nodejs/node@1c271b162b)] - **doc**: make first parameter optional in `util.getCallSites` (Deokjin Kim) [#57387](nodejs/node#57387) - \[[`77668fffec`](nodejs/node@77668fffec)] - **doc**: fix usage of module.registerSync in comment (Timo Kössler) [#57328](nodejs/node#57328) - \[[`9b4f7aac69`](nodejs/node@9b4f7aac69)] - **doc**: add Darshan back as voting TSC member (Michael Dawson) [#57402](nodejs/node#57402) - \[[`d44ccb319c`](nodejs/node@d44ccb319c)] - **doc**: revise webcrypto.md types, interfaces, and added versions (Filip Skokan) [#57376](nodejs/node#57376) - \[[`f4de7cef01`](nodejs/node@f4de7cef01)] - **doc**: add info on how project manages social media (Michael Dawson) [#57318](nodejs/node#57318) - \[[`792ef16921`](nodejs/node@792ef16921)] - **doc**: revise `tsconfig.json` note (Steven) [#57353](nodejs/node#57353) - \[[`4e438c3fa3`](nodejs/node@4e438c3fa3)] - **doc**: use more clear name in getSystemErrorMessage's example (ikuma-t) [#57310](nodejs/node#57310) - \[[`5c9f1a40e4`](nodejs/node@5c9f1a40e4)] - **doc**: recommend setting `noEmit: true` in `tsconfig.json` (Steven) [#57320](nodejs/node#57320) - \[[`e178acf9d8`](nodejs/node@e178acf9d8)] - **doc**: ping nodejs/tsc for each security pull request (Rafael Gonzaga) [#57309](nodejs/node#57309) - \[[`fbe464e28c`](nodejs/node@fbe464e28c)] - **doc**: fix Windows ccache section position (Stefan Stojanovic) [#57326](nodejs/node#57326) - \[[`3fe8eac0ba`](nodejs/node@3fe8eac0ba)] - **doc**: update node-api version matrix (Chengzhong Wu) [#57287](nodejs/node#57287) - \[[`d2f49e7fcf`](nodejs/node@d2f49e7fcf)] - **doc**: recommend `erasableSyntaxOnly` in ts docs (Rob Palmer) [#57271](nodejs/node#57271) - \[[`03844d99f8`](nodejs/node@03844d99f8)] - **doc**: clarify `path.isAbsolute` is not path traversal mitigation (Eric Fortis) [#57073](nodejs/node#57073) - \[[`0f8cd32986`](nodejs/node@0f8cd32986)] - **doc**: fix rendering of DEP0174 description (David Sanders) [#56835](nodejs/node#56835) - \[[`f95ecca71f`](nodejs/node@f95ecca71f)] - **doc**: add 1ilsang to triage team (1ilsang) [#57183](nodejs/node#57183) - \[[`6fd2ec6816`](nodejs/node@6fd2ec6816)] - **doc**: add [@geeksilva97](https://github.com/geeksilva97) to collaborators (Edy Silva) [#57241](nodejs/node#57241) - \[[`b74e0ff7d7`](nodejs/node@b74e0ff7d7)] - **doc**: add missing assert return types (Colin Ihrig) [#57219](nodejs/node#57219) - \[[`83eed33562`](nodejs/node@83eed33562)] - **doc**: add streamResetBurst and streamResetRate (Sujal Raj) [#57195](nodejs/node#57195) - \[[`7f48811295`](nodejs/node@7f48811295)] - **doc**: add esm examples to node:util (Alfredo González) [#56793](nodejs/node#56793) - \[[`5c20dcc166`](nodejs/node@5c20dcc166)] - **esm**: fix module.exports export on CJS modules (Guy Bedford) [#57366](nodejs/node#57366) - \[[`041a217a4d`](nodejs/node@041a217a4d)] - **fs**: fix rmSync error code (Paul Schwabauer) [#57103](nodejs/node#57103) - \[[`cea50b7f39`](nodejs/node@cea50b7f39)] - **lib**: optimize priority queue (Gürgün Dayıoğlu) [#57100](nodejs/node#57100) - \[[`5204d495ae`](nodejs/node@5204d495ae)] - **meta**: bump codecov/codecov-action from 5.3.1 to 5.4.0 (dependabot\[bot]) [#57257](nodejs/node#57257) - \[[`89599be988`](nodejs/node@89599be988)] - **meta**: bump github/codeql-action from 3.28.8 to 3.28.10 (dependabot\[bot]) [#57254](nodejs/node#57254) - \[[`66cd3850bc`](nodejs/node@66cd3850bc)] - **meta**: bump ossf/scorecard-action from 2.4.0 to 2.4.1 (dependabot\[bot]) [#57253](nodejs/node#57253) - \[[`6c22e446bc`](nodejs/node@6c22e446bc)] - **meta**: set nodejs/config as codeowner (Marco Ippolito) [#57237](nodejs/node#57237) - \[[`ee5ce5ccde`](nodejs/node@ee5ce5ccde)] - **meta**: move RaisinTen back to collaborators, triagers and SEA champion (Darshan Sen) [#57292](nodejs/node#57292) - \[[`0b0c9cc0f5`](nodejs/node@0b0c9cc0f5)] - **meta**: bump actions/download-artifact from 4.1.8 to 4.1.9 (dependabot\[bot]) [#57260](nodejs/node#57260) - \[[`e6a98af8bd`](nodejs/node@e6a98af8bd)] - **meta**: bump peter-evans/create-pull-request from 7.0.6 to 7.0.7 (dependabot\[bot]) [#57259](nodejs/node#57259) - \[[`91394aaf3d`](nodejs/node@91394aaf3d)] - **meta**: bump step-security/harden-runner from 2.10.4 to 2.11.0 (dependabot\[bot]) [#57258](nodejs/node#57258) - \[[`63dbbe7c91`](nodejs/node@63dbbe7c91)] - **meta**: bump actions/cache from 4.2.0 to 4.2.2 (dependabot\[bot]) [#57256](nodejs/node#57256) - \[[`d5ccf174ad`](nodejs/node@d5ccf174ad)] - **meta**: bump actions/upload-artifact from 4.6.0 to 4.6.1 (dependabot\[bot]) [#57255](nodejs/node#57255) - \[[`46b06be9a3`](nodejs/node@46b06be9a3)] - **module**: handle cached linked async jobs in require(esm) (Joyee Cheung) [#57187](nodejs/node#57187) - \[[`718305db6f`](nodejs/node@718305db6f)] - **module**: add dynamic file-specific ESM warnings (Mert Can Altin) [#56628](nodejs/node#56628) - \[[`4762f4ada5`](nodejs/node@4762f4ada5)] - **net**: validate non-string host for socket.connect (Daeyeon Jeong) [#57198](nodejs/node#57198) - \[[`d07bd79ac5`](nodejs/node@d07bd79ac5)] - **net**: replace brand checks with identity checks (Yagiz Nizipli) [#57341](nodejs/node#57341) - \[[`a757f00747`](nodejs/node@a757f00747)] - **net**: emit an error when custom lookup resolves to a non-string address (Edy Silva) [#57192](nodejs/node#57192) - \[[`984f7ef5bd`](nodejs/node@984f7ef5bd)] - **readline**: add support for `Symbol.dispose` (Antoine du Hamel) [#57276](nodejs/node#57276) - \[[`21b6423b9b`](nodejs/node@21b6423b9b)] - **sqlite**: reset statement immediately in run() (Colin Ihrig) [#57350](nodejs/node#57350) - \[[`e80bbb7355`](nodejs/node@e80bbb7355)] - **sqlite,test,doc**: allow Buffer and URL as database location (Edy Silva) [#56991](nodejs/node#56991) - \[[`3dc3207298`](nodejs/node@3dc3207298)] - **src**: do not pass nullptr to std::string ctor (Charles Kerr) [#57354](nodejs/node#57354) - \[[`5e51c62569`](nodejs/node@5e51c62569)] - **src**: fix process exit listeners not receiving unsettled tla codes (Dario Piotrowicz) [#56872](nodejs/node#56872) - \[[`bf788d9d86`](nodejs/node@bf788d9d86)] - **src**: refactor SubtleCrypto algorithm and length validations (Filip Skokan) [#57319](nodejs/node#57319) - \[[`37664e8485`](nodejs/node@37664e8485)] - **src**: fix node_config_file.h compilation error in GN build (Cheng) [#57210](nodejs/node#57210) - \[[`274c18a365`](nodejs/node@274c18a365)] - **(SEMVER-MINOR)** **src**: set default config as node.config.json (Marco Ippolito) [#57171](nodejs/node#57171) - \[[`433657de8c`](nodejs/node@433657de8c)] - **src**: namespace config file flags (Marco Ippolito) [#57170](nodejs/node#57170) - \[[`d8937f1742`](nodejs/node@d8937f1742)] - **(SEMVER-MINOR)** **src**: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING (Marco Ippolito) [#57016](nodejs/node#57016) - \[[`9fd217daa9`](nodejs/node@9fd217daa9)] - **(SEMVER-MINOR)** **src**: add config file support (Marco Ippolito) [#57016](nodejs/node#57016) - \[[`b17163b130`](nodejs/node@b17163b130)] - **src**: allow embedder customization of OOMErrorHandler (Shelley Vohr) [#57325](nodejs/node#57325) - \[[`6f1c622466`](nodejs/node@6f1c622466)] - **src**: use Maybe\<void> in ProcessEmitWarningSync (Daeyeon Jeong) [#57250](nodejs/node#57250) - \[[`4d86a42aa4`](nodejs/node@4d86a42aa4)] - **src**: remove redundant qualifiers in src/quic (Yagiz Nizipli) [#56967](nodejs/node#56967) - \[[`41ea5a2864`](nodejs/node@41ea5a2864)] - **src**: make even more improvements to error handling (James M Snell) [#57264](nodejs/node#57264) - \[[`7a554d9bf3`](nodejs/node@7a554d9bf3)] - **src**: use cached `emit` v8::String (Daeyeon Jeong) [#57249](nodejs/node#57249) - \[[`b10ac9a958`](nodejs/node@b10ac9a958)] - **src**: refactor SubtleCrypto algorithm and length validations (Filip Skokan) [#57273](nodejs/node#57273) - \[[`90cd780ca6`](nodejs/node@90cd780ca6)] - **src**: make more error handling improvements (James M Snell) [#57262](nodejs/node#57262) - \[[`17c9e76722`](nodejs/node@17c9e76722)] - **src**: fix typo in comment (Antoine du Hamel) [#57291](nodejs/node#57291) - \[[`35c283a3f3`](nodejs/node@35c283a3f3)] - **src**: reduce string allocations on sqlite (Yagiz Nizipli) [#57227](nodejs/node#57227) - \[[`185d1ffe93`](nodejs/node@185d1ffe93)] - **src**: improve error handling in `node_messaging.cc` (James M Snell) [#57211](nodejs/node#57211) - \[[`96b2bfb88c`](nodejs/node@96b2bfb88c)] - **src**: improve error handling in `tty_wrap.cc` (James M Snell) [#57211](nodejs/node#57211) - \[[`f845ad953e`](nodejs/node@f845ad953e)] - **src**: improve error handling in `tcp_wrap.cc` (James M Snell) [#57211](nodejs/node#57211) - \[[`350f62de6c`](nodejs/node@350f62de6c)] - **src**: fix ThrowInvalidURL call in PathToFileURL (Daniel M Brasil) [#57141](nodejs/node#57141) - \[[`936a9997b2`](nodejs/node@936a9997b2)] - **src**: improve error handling in buffer and dotenv (James M Snell) [#57189](nodejs/node#57189) - \[[`975e2a5c1d`](nodejs/node@975e2a5c1d)] - **src**: improve error handling in module_wrap (James M Snell) [#57188](nodejs/node#57188) - \[[`3d103ecfbe`](nodejs/node@3d103ecfbe)] - **src**: improve error handling in spawn_sync (James M Snell) [#57185](nodejs/node#57185) - \[[`98d328a1d6`](nodejs/node@98d328a1d6)] - **src**: detect whether the string is one byte representation or not (theweipeng) [#56147](nodejs/node#56147) - \[[`15d7908656`](nodejs/node@15d7908656)] - **stream**: fix sizeAlgorithm validation in WritableStream (Daeyeon Jeong) [#57280](nodejs/node#57280) - \[[`b866755299`](nodejs/node@b866755299)] - **test**: test runner run plan (Pietro Marchini) [#57304](nodejs/node#57304) - \[[`e05e0e5772`](nodejs/node@e05e0e5772)] - **test**: update WPT for urlpattern to [`3b6b198`](nodejs/node@3b6b19853a) (Node.js GitHub Bot) [#57377](nodejs/node#57377) - \[[`36542b5611`](nodejs/node@36542b5611)] - **test**: update WPT for WebCryptoAPI to [`edd42c0`](nodejs/node@edd42c005c) (Node.js GitHub Bot) [#57365](nodejs/node#57365) - \[[`28792ee59a`](nodejs/node@28792ee59a)] - **test**: skip `test-config-json-schema` with quic (Richard Lau) [#57225](nodejs/node#57225) - \[[`5a21fa4573`](nodejs/node@5a21fa4573)] - **test**: add more coverage to node_config_file (Marco Ippolito) [#57170](nodejs/node#57170) - \[[`99b2369142`](nodejs/node@99b2369142)] - **test**: simplify test-tls-connect-abort-controller.js (Yagiz Nizipli) [#57338](nodejs/node#57338) - \[[`4af2f7f9a8`](nodejs/node@4af2f7f9a8)] - **test**: use `assert.match` in `test-esm-import-meta` (Antoine du Hamel) [#57290](nodejs/node#57290) - \[[`99abfb6172`](nodejs/node@99abfb6172)] - **test**: update compression wpt (Yagiz Nizipli) [#56960](nodejs/node#56960) - \[[`f8dde3a391`](nodejs/node@f8dde3a391)] - **test**: skip uv-thread-name on IBM i (Abdirahim Musse) [#57299](nodejs/node#57299) - \[[`3bf546c317`](nodejs/node@3bf546c317)] - ***Revert*** "**test**: temporary remove resource check from fs read-write" (Rafael Gonzaga) [#56906](nodejs/node#56906) - \[[`8d0f1a7dbf`](nodejs/node@8d0f1a7dbf)] - **test**: module syntax should throw (Marco Ippolito) [#57121](nodejs/node#57121) - \[[`0fd3d91e3a`](nodejs/node@0fd3d91e3a)] - **test**: more common.mustNotCall in net, tls (Meghan Denny) [#57246](nodejs/node#57246) - \[[`f803d6ca29`](nodejs/node@f803d6ca29)] - **test**: swap assert.strictEqual() parameters (Luigi Pinca) [#57217](nodejs/node#57217) - \[[`eb3576fde0`](nodejs/node@eb3576fde0)] - **test**: assert write return values in buffer-bigint64 (Meghan Denny) [#57212](nodejs/node#57212) - \[[`a08981025a`](nodejs/node@a08981025a)] - **test**: allow embedder running async context frame test (Shelley Vohr) [#57193](nodejs/node#57193) - \[[`20c032ed98`](nodejs/node@20c032ed98)] - **test**: resolve race condition in test-net-write-fully-async-\* (Matteo Collina) [#57022](nodejs/node#57022) - \[[`5054fc7941`](nodejs/node@5054fc7941)] - **(SEMVER-MINOR)** **test_runner**: change ts default glob (Marco Ippolito) [#57359](nodejs/node#57359) - \[[`0ad450f295`](nodejs/node@0ad450f295)] - **timers**: simplify the compareTimersLists function (Gürgün Dayıoğlu) [#57110](nodejs/node#57110) - \[[`75f11ae1cc`](nodejs/node@75f11ae1cc)] - **(SEMVER-MINOR)** **tls**: implement tls.getCACertificates() (Joyee Cheung) [#57107](nodejs/node#57107) - \[[`2b2267f203`](nodejs/node@2b2267f203)] - **tools**: add config subspace (Marco Ippolito) [#57239](nodejs/node#57239) - \[[`8e64d38e91`](nodejs/node@8e64d38e91)] - **tools**: import rather than require ESLint plugins (Michaël Zasso) [#57315](nodejs/node#57315) - \[[`2569e56b95`](nodejs/node@2569e56b95)] - **tools**: switch back to official OpenSSL (Richard Lau) [#57301](nodejs/node#57301) - \[[`fd49144378`](nodejs/node@fd49144378)] - **tools**: extract target abseil to abseil.gyp (Chengzhong Wu) [#57289](nodejs/node#57289) - \[[`77e1a85d24`](nodejs/node@77e1a85d24)] - **tools**: revert to use [@stylistic/eslint-plugin-js](https://github.com/stylistic/eslint-plugin-js) v3 (Joyee Cheung) [#57314](nodejs/node#57314) - \[[`2fa6e65262`](nodejs/node@2fa6e65262)] - **tools**: add more details about rolling inspector_protocol (Chengzhong Wu) [#57167](nodejs/node#57167) - \[[`5788574cdf`](nodejs/node@5788574cdf)] - **tools**: bump the eslint group in /tools/eslint with 5 updates (dependabot\[bot]) [#57261](nodejs/node#57261) - \[[`5955acadba`](nodejs/node@5955acadba)] - **tools**: remove deps/zlib/GN-scraper.py (Chengzhong Wu) [#57238](nodejs/node#57238) - \[[`a22c21ceb8`](nodejs/node@a22c21ceb8)] - **(SEMVER-MINOR)** **v8**: add v8.getCppHeapStatistics() method (Aditi) [#57146](nodejs/node#57146) - \[[`17d4074114`](nodejs/node@17d4074114)] - **win,build**: add option to enable Control Flow Guard (Hüseyin Açacak) [#56605](nodejs/node#56605) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Dec 5, 2024

theweipeng force-pushed the issue_56090 branch from 8944a8c to a4a445a Compare December 7, 2024 11:22

theweipeng mentioned this pull request Dec 10, 2024

Proposal: Add a method to check if a string is a OneByteString #56090

Closed

theweipeng changed the title ~~util: add a method to get string encoding info~~ src: add a method to get string encoding info Dec 16, 2024

jakecastelli added request-ci Add this label to start a Jenkins CI on a PR. review wanted PRs that need reviews. labels Dec 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024

jazelly requested a review from joyeecheung December 17, 2024 14:40

addaleax previously requested changes Dec 17, 2024

View reviewed changes

jazelly removed the request for review from joyeecheung December 18, 2024 04:24

theweipeng force-pushed the issue_56090 branch 3 times, most recently from 8a6f12e to 6f30b0e Compare December 21, 2024 14:20

addaleax reviewed Dec 21, 2024

View reviewed changes

doc/api/v8.md Outdated Show resolved Hide resolved

theweipeng force-pushed the issue_56090 branch from 6f30b0e to 6eaf64c Compare December 22, 2024 09:45

theweipeng requested a review from addaleax December 25, 2024 03:03

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2024

doc: simplify the document

34d144f

legendecas reviewed Jan 3, 2025

View reviewed changes

test/parallel/test-v8-string-is-one-byte-representation.js Outdated Show resolved Hide resolved

doc: remove unused flags

bd086ce

legendecas added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2025

theweipeng mentioned this pull request Jan 9, 2025

feat(javascript): removing HPS apache/fury#2001

Closed

addaleax approved these changes Feb 21, 2025

View reviewed changes

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

This comment was marked as outdated.

Sign in to view

jasnell pushed a commit that referenced this pull request Feb 25, 2025

src: detect whether the string is one byte representation or not

6cb0690

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

jasnell closed this Feb 25, 2025

aduh95 pushed a commit that referenced this pull request Mar 9, 2025

src: detect whether the string is one byte representation or not

98d328a

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

github-actions bot mentioned this pull request Mar 12, 2025

2025-03-13, Version 23.10.0 (Current) #57424

Merged

RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025

src: detect whether the string is one byte representation or not

d23d091

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025

src: detect whether the string is one byte representation or not

fe702a0

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

aduh95 pushed a commit that referenced this pull request Apr 2, 2025

src: detect whether the string is one byte representation or not

df96d1c

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

aduh95 pushed a commit that referenced this pull request Apr 3, 2025

src: detect whether the string is one byte representation or not

ca510d1

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

aduh95 mentioned this pull request Apr 11, 2025

2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840

Merged

RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025

src: detect whether the string is one byte representation or not

b2f9c9d

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025

src: detect whether the string is one byte representation or not

9221c2a

References: #56090 PR-URL: #56147 Fixes: #56090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: add a method to get string encoding info #56147

src: add a method to get string encoding info #56147

theweipeng commented Dec 5, 2024 •

edited

Loading

codecov bot commented Dec 5, 2024 •

edited

Loading

theweipeng commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

addaleax left a comment

addaleax commented Dec 17, 2024 •

edited

Loading

theweipeng commented Dec 18, 2024

addaleax left a comment

theweipeng commented Dec 26, 2024

nodejs-github-bot commented Dec 26, 2024

theweipeng commented Dec 27, 2024

nodejs-github-bot commented Dec 27, 2024

nodejs-github-bot commented Jan 3, 2025

addaleax commented Jan 3, 2025 •

edited

Loading

theweipeng commented Jan 4, 2025 •

edited

Loading

theweipeng commented Jan 16, 2025

This comment was marked as outdated.

nodejs-github-bot commented Feb 21, 2025 •

edited by jasnell

Loading

theweipeng commented Feb 24, 2025

jasnell commented Feb 25, 2025

src: add a method to get string encoding info #56147

src: add a method to get string encoding info #56147

Conversation

theweipeng commented Dec 5, 2024 • edited Loading

codecov bot commented Dec 5, 2024 • edited Loading

Codecov Report

theweipeng commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

addaleax left a comment

Choose a reason for hiding this comment

addaleax commented Dec 17, 2024 • edited Loading

theweipeng commented Dec 18, 2024

addaleax left a comment

Choose a reason for hiding this comment

theweipeng commented Dec 26, 2024

nodejs-github-bot commented Dec 26, 2024

theweipeng commented Dec 27, 2024

nodejs-github-bot commented Dec 27, 2024

nodejs-github-bot commented Jan 3, 2025

addaleax commented Jan 3, 2025 • edited Loading

theweipeng commented Jan 4, 2025 • edited Loading

theweipeng commented Jan 16, 2025

This comment was marked as outdated.

nodejs-github-bot commented Feb 21, 2025 • edited by jasnell Loading

theweipeng commented Feb 24, 2025

jasnell commented Feb 25, 2025

theweipeng commented Dec 5, 2024 •

edited

Loading

codecov bot commented Dec 5, 2024 •

edited

Loading

addaleax commented Dec 17, 2024 •

edited

Loading

addaleax commented Jan 3, 2025 •

edited

Loading

theweipeng commented Jan 4, 2025 •

edited

Loading

nodejs-github-bot commented Feb 21, 2025 •

edited by jasnell

Loading