Fix params usage for file() call without options

porsager · porsager · commit e4f12a4e6ab8 · 2019-12-23T23:04:19.000+01:00
diff --git a/lib/index.js b/lib/index.js
@@ -254,7 +254,7 @@ function Postgres(url, options) {
       return query({ raw: true, simple: !args, dynamic: true }, connection || getConnection(), xs, args || [])
     }
 
-    function file(path, args, options) {
+    function file(path, args, options = {}) {
       if (!Array.isArray(args)) {
         options = args || {}
         args = null
diff --git a/tests/index.js b/tests/index.js
@@ -353,6 +353,14 @@ t('sql file cached', async() => {
   return [1, (await sql.file(path.join(__dirname, 'select.sql')))[0].x]
 })
 
+t('Parameters in file', async() => {
+  const result = await sql.file(
+    path.join(__dirname, 'select-param.sql'),
+    ['hello']
+  )
+  return ['hello', result[0].x]
+})
+
 t('Connection ended promise', async() => {
   const sql = postgres(options)
 
diff --git a/tests/select-param.sql b/tests/select-param.sql
@@ -0,0 +1 @@
+select $1 as x

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ function Postgres(url, options) {`
`254`	`254`	`return query({ raw: true, simple: !args, dynamic: true }, connection \|\| getConnection(), xs, args \|\| [])`
`255`	`255`	`}`
`256`	`256`
`257`		`- function file(path, args, options) {`
	`257`	`+ function file(path, args, options = {}) {`
`258`	`258`	`if (!Array.isArray(args)) {`
`259`	`259`	`options = args \|\| {}`
`260`	`260`	`args = null`