Implement committed.Iterator.NextRange() without recursive call (treeverse#1365)

arielshaqed · web-flow · commit 7f44f1e27fdf · 2021-01-31T17:58:32.000+02:00
Better because golang does not support tail recursion. Fixes treeverse#1178.
diff --git a/graveler/committed/iterator.go b/graveler/committed/iterator.go
@@ -45,12 +45,13 @@ func (rvi *iterator) NextRange() bool {
 	}
 	rvi.it = nil
 	rvi.rng = nil
-	if !rvi.rangesIt.Next() {
-		return false
-	}
-	rngRecord := rvi.rangesIt.Value()
-	if rngRecord == nil {
-		return rvi.NextRange()
+
+	var rngRecord *Record
+	for rngRecord == nil { // Skip this and any consecutive finished ranges.
+		if !rvi.rangesIt.Next() {
+			return false
+		}
+		rngRecord = rvi.rangesIt.Value()
 	}
 
 	gv, err := UnmarshalValue(rngRecord.Value)
