Test batch closer with parllelism (treeverse#1396)

itaiad200 · web-flow · commit b392494cabbd · 2021-02-03T17:55:17.000+02:00
diff --git a/graveler/committed/batch_test.go b/graveler/committed/batch_test.go
@@ -92,7 +92,7 @@ func NewFakeRangeWriter(result *committed.WriteResult, err error) *FakeRangeWrit
 }
 
 func TestBatchCloserSuccess(t *testing.T) {
-	runSuccessScenario(t)
+	runSuccessScenario(t, 502, 5)
 }
 
 func TestBatchWriterFailed(t *testing.T) {
@@ -126,18 +126,19 @@ func TestBatchCloserMultipleWaitCalls(t *testing.T) {
 		Count:   4321,
 	}, nil)
 
-	sut := runSuccessScenario(t)
+	sut := runSuccessScenario(t, 1, 1)
 
 	assert.Error(t, sut.CloseWriterAsync(writer), committed.ErrMultipleWaitCalls)
 	res, err := sut.Wait()
 	require.Nil(t, res)
 	require.Error(t, err, committed.ErrMultipleWaitCalls)
 }
 
-func runSuccessScenario(t *testing.T) *committed.BatchCloser {
-	const writersCount = 10
-	writers := make([]*FakeRangeWriter, writersCount)
-	for i := 0; i < writersCount; i++ {
+func runSuccessScenario(t *testing.T, numWriters, numClosers int) *committed.BatchCloser {
+	t.Helper()
+
+	writers := make([]*FakeRangeWriter, numWriters)
+	for i := 0; i < numWriters; i++ {
 		writers[i] = NewFakeRangeWriter(&committed.WriteResult{
 			RangeID: committed.ID(strconv.Itoa(i)),
 			First:   committed.Key(fmt.Sprintf("row_%d_1", i)),
@@ -146,16 +147,16 @@ func runSuccessScenario(t *testing.T) *committed.BatchCloser {
 		}, nil)
 	}
 
-	sut := committed.NewBatchCloser(writersCount)
+	sut := committed.NewBatchCloser(numClosers)
 
-	for i := 0; i < writersCount; i++ {
+	for i := 0; i < numWriters; i++ {
 		assert.NoError(t, sut.CloseWriterAsync(writers[i]))
 	}
 
 	res, err := sut.Wait()
 	assert.NoError(t, err)
 	assert.NotNil(t, res)
-	assert.Len(t, res, writersCount)
+	assert.Len(t, res, numWriters)
 
 	return sut
 }
