Accept numbers and other value types in escapeId

XadillaX · dougwilson · commit cee35931f76d · 2016-08-26T15:57:10.000-04:00
closes mysqljs#5
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+  * Accept numbers and other value types in `escapeId`
   * Run `buffer.toString()` through escaping
 
 2.0.1 / 2016-06-06
diff --git a/lib/SqlString.js b/lib/SqlString.js
@@ -24,10 +24,10 @@ SqlString.escapeId = function escapeId(val, forbidQualified) {
   }
 
   if (forbidQualified) {
-    return '`' + val.replace(/`/g, '``') + '`';
+    return '`' + String(val).replace(/`/g, '``') + '`';
   }
 
-  return '`' + val.replace(/`/g, '``').replace(/\./g, '`.`') + '`';
+  return '`' + String(val).replace(/`/g, '``').replace(/\./g, '`.`') + '`';
 };
 
 SqlString.escape = function escape(val, stringifyObjects, timeZone) {
diff --git a/test/unit/test-SqlString.js b/test/unit/test-SqlString.js
@@ -7,6 +7,10 @@ test('SqlString.escapeId', {
     assert.equal('`id`', SqlString.escapeId('id'));
   },
 
+  'value can be a number': function() {
+    assert.equal('`42`', SqlString.escapeId(42));
+  },
+
   'value containing escapes is quoted': function() {
     assert.equal('`i``d`', SqlString.escapeId('i`d'));
   },

Original file line number	Diff line number	Diff line change
`@@ -24,10 +24,10 @@ SqlString.escapeId = function escapeId(val, forbidQualified) {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`if (forbidQualified) {`
`27`		- return '`' + val.replace(/`/g, '``') + '`';
	`27`	+ return '`' + String(val).replace(/`/g, '``') + '`';
`28`	`28`	`}`
`29`	`29`
`30`		- return '`' + val.replace(/`/g, '``').replace(/\./g, '`.`') + '`';
	`30`	+ return '`' + String(val).replace(/`/g, '``').replace(/\./g, '`.`') + '`';
`31`	`31`	`};`
`32`	`32`
`33`	`33`	`SqlString.escape = function escape(val, stringifyObjects, timeZone) {`