fix(table): filtered event not firing when filter cleared (issue bootstrap-vue#859) (bootstrap-vue#860)

tmorehouse · web-flow · commit 4e28726ccc17 · 2017-08-15T16:19:21.000-03:00
* fix(table): filtered event not firing when filter cleared (issue bootstrap-vue#859) Addresses issue bootstrap-vue#859 in v0.x branch * Update table.vue
diff --git a/lib/components/table.vue b/lib/components/table.vue
@@ -124,7 +124,9 @@
             return {
                 localSortBy: this.sortBy || '',
                 localSortDesc: this.sortDesc || false,
-                localItems: []
+                localItems: [],
+                // Note: filteredItems only used to determine if # of items changed
+                filteredItems: []
             };
         },
         props: {
@@ -263,6 +265,12 @@
                     this._providerUpdate();
                 }
             },
+            filteredItems(newVal, oldVal) {
+                if (!this.providerFiltering && newVal.length !== oldVal.length) {
+                    // Emit a filtered notification event, as number of filtered items has changed
+                    this.$emit('filtered', newVal);
+                }
+            },
             sortDesc(newVal, oldVal) {
                 if (newVal === this.localSortDesc) {
                     return;
@@ -383,9 +391,6 @@
 
                 // Apply local filter
                 if (filter && !this.providerFiltering) {
-                    // Number of items before filtering
-                    const numOriginalItems = items.length;
-
                     if (filter instanceof Function) {
                         items = items.filter(filter);
                     } else {
@@ -401,11 +406,10 @@
                             return test;
                         });
                     }
-
-                    if (numOriginalItems !== items.length) {
-                        // Emit a filtered notification event, as number of items has changed
-                        this.$emit('filtered', items);
-                    }
+                }
+                if (!this.providerFiltering) {
+                    // Make a local copy of filtered items to trigger filtered event
+                    this.filteredItems = items.slice();
                 }
 
                 // Apply local Sort
