fix: replace console.error with proper logger throughout API

nullcoder · Claude · nullcoder · commit 0e5a58b549fe · 2025-06-07T16:40:41.000-07:00
Replaces all console.error calls with proper logger usage for consistency and better error tracking across the API layer. ## Changes - **api-errors.ts**: Replace console.error with createLogger("api-errors") - **gists/route.ts**: Replace console.error with createLogger("api:gists:post") - **api-errors.test.ts**: Update test mocks to use logger instead of console.error ## Benefits - Consistent logging format with timestamps and context - Better error tracking and debugging capability - Follows established logging patterns throughout codebase - Proper error object handling instead of raw console output 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <claude@ghostpaste.dev>
diff --git a/app/api/gists/route.ts b/app/api/gists/route.ts
@@ -5,6 +5,7 @@ import { FILE_LIMITS } from "@/lib/constants";
 import { AppError } from "@/types/errors";
 import { generateSalt, hashPin } from "@/lib/auth";
 import { errorResponse, ApiErrors, validationError } from "@/lib/api-errors";
+import { createLogger } from "@/lib/logger";
 import type { CreateGistResponse } from "@/types/api";
 import type { GistMetadata } from "@/types/models";
 
@@ -57,6 +58,8 @@ async function parseMultipartFormData(request: NextRequest): Promise<{
   };
 }
 
+const logger = createLogger("api:gists:post");
+
 /**
  * POST /api/gists
  * Creates a new encrypted gist
@@ -160,12 +163,18 @@ export async function POST(request: NextRequest) {
       }
 
       // Log unexpected errors
-      console.error("Storage error:", error);
+      logger.error(
+        "Storage error:",
+        error instanceof Error ? error : new Error(String(error))
+      );
       return errorResponse(ApiErrors.storageError("Failed to store gist data"));
     }
   } catch (error) {
     // Handle unexpected errors
-    console.error("Unexpected error in POST /api/gists:", error);
+    logger.error(
+      "Unexpected error in POST /api/gists:",
+      error instanceof Error ? error : new Error(String(error))
+    );
     return errorResponse(
       error instanceof Error ? error : new Error("Unknown error")
     );
diff --git a/lib/api-errors.test.ts b/lib/api-errors.test.ts
@@ -15,10 +15,21 @@ vi.mock("next/server", () => ({
   },
 }));
 
+// Mock logger
+const mockLogger = {
+  error: vi.fn(),
+  warn: vi.fn(),
+  info: vi.fn(),
+  debug: vi.fn(),
+};
+
+vi.mock("@/lib/logger", () => ({
+  createLogger: vi.fn(() => mockLogger),
+}));
+
 describe("API Error Utilities", () => {
   beforeEach(() => {
     vi.clearAllMocks();
-    vi.spyOn(console, "error").mockImplementation(() => {});
   });
 
   describe("toApiErrorResponse", () => {
@@ -74,7 +85,7 @@ describe("API Error Utilities", () => {
 
       errorResponse(error);
 
-      expect(console.error).toHaveBeenCalledWith("Unexpected error:", error);
+      expect(mockLogger.error).toHaveBeenCalledWith("Unexpected error:", error);
       expect(NextResponse.json).toHaveBeenCalledWith(
         {
           error: ErrorCode.INTERNAL_SERVER_ERROR,
diff --git a/lib/api-errors.ts b/lib/api-errors.ts
@@ -5,6 +5,7 @@
 import { NextResponse } from "next/server";
 import { AppError, ErrorCode } from "@/types/errors";
 import type { ApiErrorResponse } from "@/types/api";
+import { createLogger } from "@/lib/logger";
 
 /**
  * Convert an AppError to ApiErrorResponse format
@@ -30,7 +31,11 @@ export function errorResponse(
   }
 
   // Handle unexpected errors
-  console.error("Unexpected error:", error);
+  const logger = createLogger("api-errors");
+  logger.error(
+    "Unexpected error:",
+    error instanceof Error ? error : new Error(String(error))
+  );
   return NextResponse.json<ApiErrorResponse>(
     {
       error: ErrorCode.INTERNAL_SERVER_ERROR,
