tweaks

yyx990803 · yyx990803 · commit 04dc782edf3c · 2016-08-10T23:52:42.000-05:00
diff --git a/src/components/Item.vue b/src/components/Item.vue
@@ -30,9 +30,8 @@
 export default {
   name: 'news-item',
   props: ['item'],
-  serverCacheKey: ({ item: { id, __lastUpdated } }) => {
-    console.log(__lastUpdated)
-    return `${id}::${__lastUpdated}`
+  serverCacheKey: props => {
+    return `${props.item.id}::${props.item.__lastUpdated}`
   }
 }
 </script>
diff --git a/src/store/api.js b/src/store/api.js
@@ -50,6 +50,7 @@ function fetch (child) {
     return new Promise((resolve, reject) => {
       api.child(child).once('value', snapshot => {
         const val = snapshot.val()
+        // mark the timestamp when this item is cached
         val.__lastUpdated = Date.now()
         cache && cache.set(child, val)
         resolve(val)
diff --git a/src/store/index.js b/src/store/index.js
@@ -21,7 +21,7 @@ const store = new Vuex.Store({
 
   actions: {
     // ensure data for rendering given list type
-    FETCH_LIST_DATA: ({ commit, dispatch, state, getters }, { type }) => {
+    FETCH_LIST_DATA: ({ commit, dispatch, state }, { type }) => {
       commit('SET_ACTIVE_TYPE', { type })
       return fetchIdsByType(type)
         .then(ids => commit('SET_LIST', { type, ids }))

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,8 @@`
`30`	`30`	`export default {`
`31`	`31`	`name: 'news-item',`
`32`	`32`	`props: ['item'],`
`33`		`- serverCacheKey: ({ item: { id, __lastUpdated } }) => {`
`34`		`- console.log(__lastUpdated)`
`35`		- return `${id}::${__lastUpdated}`
	`33`	`+ serverCacheKey: props => {`
	`34`	+ return `${props.item.id}::${props.item.__lastUpdated}`
`36`	`35`	`}`
`37`	`36`	`}`
`38`	`37`	`</script>`