BLD: mangle the before_build script to set up link libraries [wheel build]

mattip · mattip · commit 00d15395ab5b · 2024-01-01T10:32:23.000+02:00
diff --git a/numpy/meson.build b/numpy/meson.build
@@ -243,7 +243,7 @@ python_sources = [
   'version.pyi',
 ]
 
-if blas_name == 'scipy-openblas'
+if fs.exists('_distributor_init_local.py')
   python_sources += ['_distributor_init_local.py']
 endif
 
diff --git a/pyproject.toml b/pyproject.toml
@@ -142,7 +142,6 @@ tracker = "https://github.com/numpy/numpy/issues"
 # `tools/ci/cirrus_wheels.yml`.
 build-frontend = "build"
 skip = "cp36-* cp37-* cp-38* pp37-* *-manylinux_i686 *_ppc64le *_s390x"
-build-verbosity = "3"
 before-build = "bash {project}/tools/wheels/cibw_before_build.sh {project}"
 # The build will use openblas64 everywhere, except on arm64 macOS >=14.0 (uses Accelerate)
 config-settings = "setup-args=-Duse-ilp64=true setup-args=-Dallow-noblas=false build-dir=build"
@@ -154,22 +153,27 @@ manylinux-x86_64-image = "manylinux2014"
 manylinux-aarch64-image = "manylinux2014"
 musllinux-x86_64-image = "musllinux_1_1"
 # RUNNER_OS is a GitHub Actions specific env var; define it here so it works on Cirrus CI too
-environment = {RUNNER_OS="Linux"}
+[tool.cibuildwheel.linux.environment]
+RUNNER_OS="Linux"
+PKG_CONFIG_PATH="/project/.openblas"
+LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/project/.openblas/lib"
 
 [tool.cibuildwheel.macos]
 # universal2 wheels are not supported (see gh-21233), use `delocate-fuse` if you need them
 archs = "x86_64 arm64"
 test-skip = "*_universal2:arm64"
-environment = {RUNNER_OS="macOS"}
+[tool.cibuildwheel.macos.environment]
+RUNNER_OS="macOS"
+PKG_CONFIG_PATH="/project/.openblas"
+DYLD_LIBRARY_PATH="$DYLD_LIBRARY_PATH:/project/.openblas/lib"
 
 [tool.cibuildwheel.windows]
-environment = {PKG_CONFIG_PATH="C:/opt/64/lib/pkgconfig"}
-config-settings = "setup-args=--vsenv setup-args=-Duse-ilp64=true setup-args=-Dblas=openblas setup-args=-Dlapack=openblas"
+environment = {PKG_CONFIG_PATH="./.openblas"}
+config-settings = "setup-args=--vsenv setup-args=-Duse-ilp64=true setup-args=-Dblas=openblas setup-args=-Dlapack=openblas -Dallow-noblas=false"
 repair-wheel-command = "bash ./tools/wheels/repair_windows.sh {wheel} {dest_dir}"
 
 [[tool.cibuildwheel.overrides]]
 select = "*-win32"
-environment = {PKG_CONFIG_PATH="/opt/32/lib/pkgconfig"}
 config-settings = "setup-args=--vsenv setup-args=-Dallow-noblas=true"
 repair-wheel-command = ""
 
diff --git a/tools/wheels/cibw_before_build.sh b/tools/wheels/cibw_before_build.sh
@@ -25,11 +25,33 @@ fi
 
 # Install Openblas
 if [[ $INSTALL_OPENBLAS ]] ; then
-    export PKG_CONFIG_PATH=$PROJECT_DIR/.openblas
-    mkdir -p $PKG_CONFIG_PATH
+    # PKG_CONFIG_PATH=$PROJECT_DIR/.openblas
+    mkdir -p $PKG_CONFIG_PATH/lib
     python -m pip install scipy-openblas64
-    pkg_config=$(python -c "import scipy_openblas64; print(scipy_openblas64.get_pkg_config())")
-    echo $pkg_config > $PKG_CONFIG_PATH/scipy-openblas.pc
+    python -c "import scipy_openblas64; print(scipy_openblas64.get_pkg_config())" > $PKG_CONFIG_PATH/scipy-openblas.pc
+    # Explicitly link the openblas so instead of using the "import
+    # scipy-openblas64" preload trick
+    sed -e "s/Libs:.*$/Libs: \${extralib}/" -i.bak $PKG_CONFIG_PATH/scipy-openblas.pc
+    sed -e "s/-lm -lpthread -lgfortran -lquadmath//" -i.back $PKG_CONFIG_PATH/scipy-openblas.pc
+    rm $PKG_CONFIG_PATH/*.bak
+    # Also copy the shared objects to a path under $PKG_CONFIG_PATH, the build
+    # will point $LD_LIBRARY_PATH there and then auditwheel/delocate-wheel will
+    # pull these into the wheel
+    cp -r $(python -c "import os, scipy_openblas64; print(os.path.dirname(scipy_openblas64.__file__))")/lib/* $PKG_CONFIG_PATH/lib
+    pkg-config scipy-openblas --print-provides
+
+    if [[ $RUNNER_OS != "Windows" ]]; then
+        # Link the internal SONAME to the shared object,
+        # since the runtime loader will look for a file with this name
+        # objdump -p will output something like
+        # SONAME libscipy_openblas64_0.so
+        # on linux and
+        # name libscipy_openblas64_0.dylib (offset 24)
+        # on macos, so trim off the first and last parts of the line
+        soname=$(objdump -p $PKG_CONFIG_PATH/lib/libscipy* | grep -v "p-r" | grep libscipy | sed -e"s/^.*libsci/libsci/" | cut -f1 -d" ")
+        echo "linking shared object to '$soname'"
+        ln -s $PKG_CONFIG_PATH/lib/libscipy* $PKG_CONFIG_PATH/lib/$soname
+    fi
 fi
 if [[ $RUNNER_OS == "Windows" ]]; then
     # delvewheel is the equivalent of delocate/auditwheel for windows.

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ python_sources = [`
`243`	`243`	`'version.pyi',`
`244`	`244`	`]`
`245`	`245`
`246`		`-if blas_name == 'scipy-openblas'`
	`246`	`+if fs.exists('_distributor_init_local.py')`
`247`	`247`	`python_sources += ['_distributor_init_local.py']`
`248`	`248`	`endif`
`249`	`249`