Skip to content

Don't enforce double precision in lstsq #10888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhvk opened this issue Apr 11, 2018 · 2 comments
Closed

Don't enforce double precision in lstsq #10888

mhvk opened this issue Apr 11, 2018 · 2 comments
Labels
23 - Wish List 50 - Duplicate component: numpy.linalg

Comments

@mhvk
Copy link
Contributor

mhvk commented Apr 11, 2018

Similar to the case for svd (#9516), lstsq currently enforces double precision. Now that we expose the single-precision BLAS functions as gufuncs (#9980), there is no longer a need for this limitation. This is a reminder that we should allow them to be used, most easily perhaps through a new dtype argument that defaults to using double precision (for discussion, see #9980).
@mhvk mhvk mentioned this issue Apr 11, 2018
Merged
@pv
Copy link
Member

pv commented Apr 11, 2018

also
#3217
#3722

@mhvk mhvk mentioned this issue Apr 12, 2018
Open
@mhvk
Copy link
Contributor Author

mhvk commented Apr 12, 2018

closing in favour of #3722

@mhvk mhvk closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
23 - Wish List 50 - Duplicate component: numpy.linalg
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pv @mhvk