-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Feedback on NumPy codespace - tracking issue #23134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Nothing substantive, but I can report that it worked! 🎉 The conda package search and package resolution was pretty slow and creating the initial image took about 5 minutes. But after that restoring the codespace after stopping it was fast enough. I was curious about codespaces because it might be useful for Astropy as well. Looking forward to the tutorial and sharing ideas. |
@taldcroft feel free to reach out with questions and comments. Our discussion boards, and my calendar, are available. |
I had a look at this, a few comments:
|
One thing that I remembered now so that it doesn't get lost: I could build the docs just fine, but couldn't figure out how to open the generated static html. |
@seberg if you have the Live Preview extension installed in vscode you can do that by right clicking the built html file and then selecting "Open in external browser" (wording may be slightly off but the option is there) |
Thank you all for the valuable feedback! I am really happy to see the addition of micromamba to the configuration. One option for scaling its installation and maintenance for yourselves and for others is to implement it as a dev container feature [1]. Regarding fonts, those are completely configurable in VS Code [2]. If you want the fonts to be a default that are shared across all users, you can configure those in the dev container by adding customizations in the devcontainer.json [3]: "customizations": {
"vscode": {
"settings": {
"terminal.integrated.shell.linux": "/bin/bash",
"python.pythonPath": "/usr/local/bin/python",
"editor.fontFamily": "'DejaVu Sans Mono for Powerline'",
"terminal.integrated.fontFamily": "'Hack NF'"
},
"extensions": [
"be5invis.toml",
"mesonbuild.mesonbuild",
"ms-vscode.live-server"
],
} Individual users can override those defaults with their own preferences either temporarily by updating those settings, or more permanently with setting sync or using dotfiles [4]. To instruct users to initialize their conda environments, you can follow the pattern in this devcontainer [5]. "onCreateCommand": "sudo cp .devcontainer/welcome-message.txt /usr/local/etc/vscode-dev-containers/first-run-notice.txt", For toml support in VS Code you could include an extension in your dev container. The VS Code marketplace has several to choose from [6]. There's also a Meson extension [7]. And as @melissawm pointed out, the Live Preview extension [8] can help you view static files. Thanks again for all the feedback. I'd love ideas for making these things easier.
|
Thanks or the suggestion @craiglpeters. I actually tried that, but it wasn't any faster and harder to read, so I decided to stay with the
We can do that, but isn't the Codespaces default worth fixing here? What you see in the screenshot above is so bad that I'd say it should be considered broken.
Thanks, I'll try that - either do the activation or add a message (or both). |
Fair enough. Since the install is simple keeping it there is fine. IF you ever decide to work with Codespaces Prebuilds [1] a feature would benefit you because they can be installed once, and the resulting file system is reconstructed from the prebuild which can speed things up in some cases (e.g. long installations or large repository clones).
VS Code has some default settings that work well in some cases, and poorly in others. Your system may have some settings that affect how VS Code renders fonts (see this discussion e.g. on Linux systems [2]). We haven't found a good, general way of setting defaults that work across the huge array of environments where people run Codespaces. |
I need to use a full path to activate the numpy-dev environment on codespaces (noticed this today, but may have to do with #23411?)
|
Please submit all your feedback on the NumPy codespace (including positive! 🌟) in the comments below.
The text was updated successfully, but these errors were encountered: