-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
API: Support float32 in fft? #23522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See also #17801 |
Now that we allow C++ judiciously, there is a C++ version of PocketFFT that supports |
Yeah, this may have to be a silent API change, which is why I opened this: It may be good to do in a 2.0 release. Implementing it could be started now, if we are unsure about it just disabling the promotion to double, that could be hidden behind (I am not convinced that we absolutely cannot do it in a 1.x release, but I guess it may be an easier decision...) Just N.B. since |
I think it would be fine in a 1.x release, but as you note, either way we could implement it now. |
I would be very happy about this kind of change, since it brings the implementation in sync with |
FYI CuPy already supports single-precision FFT and it's one of documented deviations from NumPy: |
I think this should be implemented now, correct? (#25711) |
We currently convert float32 to 64 there! That isn't nice, lets change it?
(Sorry the reason for the brief thing was that I accidentally also opened an issue).
The text was updated successfully, but these errors were encountered: