-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
TASK,TYP: Review np.long
related (typing) overloads and tests
#25048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
np.long
related overloadsnp.long
related (typing) overloads and tests
I think one reason why I got stuck multiple times is that it is easy to forget a definition, and that seems to translate to EDIT: as of writing gh-24224 may have left |
@BvB93 I think we want to keep the 2.0.0 milestone for this, but it's probably not blocking for the release branch creation and |
Correct, I'll see if I can make some time next week to review the issue but this is by no means a blocker. |
@rgommers For the From my side there's nothing else left here. |
Let's close it for now then, if there is something remaining it's a bug now. |
Uh oh!
There was an error while loading. Please reload this page.
Proposed new feature or change:
xref #25039 and #24224
Aforementioned PRs have exposed a number of cases wherein the
np.long
re-introduction and shift to a new default int size of 64 bit have resulted in a number of failures in the typing test suite. These cases should be further reviewed and addressed appropriately.In particular this concerns the:
The text was updated successfully, but these errors were encountered: