-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Coordination: last items before branching 2.0.x #25918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I missed a comment from @ngoldbaum elsewhere, so I'll wait for at least his input here before touching the |
I’m going to try to work on a PR to fix the issues with the |
@charris I'm having a go at release notes updates now. |
@rgommers Great. |
Wheel building failed, see #25923 |
Restarted nightly wheel builds once more. |
There is one more PR unless it wrecks havoc. The DType ones were a bit stalled, there is a follow up to bump the itemsize to |
Thanks @seberg. Let me ask a few questions to really spell it out, because Chuck was already planning to call it good and create the release branch once the copy keyword regression was fixed.
|
It shouldn't take long to create the follow up, but right now the most time was always waiting for review (I will skip renaming The annoyance is fixing
I can even do that, but not quite sure how long review would take. |
Any chance we can work around that in SciPy? Getting |
Seems that while |
Quick question: over the weekend, our JAX CI jobs running against numpy nightly began failing due to this new error: In [1]: import numpy as np
In [2]: np.array(0.0, copy=False)
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
Cell In[2], line 1
----> 1 np.array(0.0, copy=False)
ValueError: Unable to avoid copy while creating an array. I know there's been some work on the |
Yes, that looks expected @jakevdp. For notes on the changes, see numpy/doc/source/release/2.0.0-notes.rst Lines 1217 to 1242 in 54469e2
This SciPy PR to adapt to the changes may be useful too: scipy/scipy#20172 |
The thing that I thought was in the release notes/migration guide: Avoid using |
Good point. It's missing from the migration guide, which is the right place I think. I'll take it along in my next PR for release notes updates. |
Thanks! |
Looks like the last PRs we need are up! One thing I'd like to suggest is to do a I imagine the following rollout scenario for releases to PyPI:
|
I am happy with a |
My impression is that error reports are either immediate, or show up after the first week, so things might move a bit slower than planned. But that is OK as long as something is out there. We can drop Python 3.9 support in main after the branch, I suggest moving more tests to Python 3.12 where they can hang around for a couple of years. |
Looks like we are almost ready. |
Yep, I think once the last release notes PR is merged, the branch can be created. |
You were right, seems if matplotlib is fine (enough). Doc builds are working again and the website is up to date again. |
@seberg are you still planning to make a change in between 2.0.0b1 and 2.0.0rc1 that turns the warning for |
🤷 that huge warning is seems only semi-useful, it would be nice to make it a hard error by the time we release, otherwise we don't protect users from potentially bad results/crashes due to a module that wasn't recompiled. |
Well, it must be done either before Probably best to wait and see how a |
The release branch is created and Thanks all! |
Posting as a new issue rather than trying to coordinate with comments on various other PRs. In the community meeting earlier this week we discussed that we are almost ready, and @charris planned to branch
maintenance/2.0.x
today. We still have a few more things to be done though it looks like.Here is what I'd propose we do today:
PyDataType_GetArrFuncs
#25897numpy.array_api
module #25911 (@rgommers)copy
argument fornp.asarray
[Array API] #25168 (because of__array__
copy keyword changes incomplete #25916) (Done in BUG: fix handling of copy keyword argument when calling __array__ #25922)npy_2_compat.h
in SciPy (MAINT: shim for descr->f access scipy/scipy#20108), getting that merged and uploading new SciPy nightliesAfter that (tomorrow?):
copy
argument fornp.asarray
[Array API] #25168 and get it merged again (@mtsokol and @ngoldbaum)still to be opened by @seberg: API: Restructure the dtype struct to be new dtype friendly #25943Other things:
Everything else under the 2.0.0 milestone seems like it can wait.
The text was updated successfully, but these errors were encountered: