Skip to content

diag still read-only #7661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akhmerov opened this issue May 22, 2016 · 5 comments
Closed

diag still read-only #7661

akhmerov opened this issue May 22, 2016 · 5 comments

Comments

@akhmerov
Copy link

It seems that the promised change of diag/diagonal to return a writeable view was forgotten in 1.10 and 1.11.

Is the fix as easy as changing the flag on creation?

@shoyer
Copy link
Member

shoyer commented May 23, 2016

We put off making this change in 1.10 after getting some significant pushback. See this blog post and the subsequent mailing list discussion (which could be turned up with some searching) for more details.

@akhmerov
Copy link
Author

Do you mean this discussion?

It seems to conclude with something like:

I would love to do the PR once a decision is reached.

Perhaps now, almost 1.5 years after the last posts in that discussion and more than 2 years after the release of v1.8 it could be a good time to re-raise the topic. Maybe it's time to do the change it in 1.12?

@shoyer
Copy link
Member

shoyer commented May 23, 2016

Yes, that looks like the right discussion. It does look like it petered out without a resolution -- I would suggest re-raising it on the mailing list.

@ahaldane
Copy link
Member

ahaldane commented Jul 6, 2016

PR #6054 implements a deprecation warning for this change, by the way. The idea would be to warn in 1.12, then implement in 1.13.

@rgommers
Copy link
Member

rgommers commented May 8, 2021

Closing as a duplicate of gh-5407.

@rgommers rgommers closed this as completed May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants