-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
diag still read-only #7661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We put off making this change in 1.10 after getting some significant pushback. See this blog post and the subsequent mailing list discussion (which could be turned up with some searching) for more details. |
Do you mean this discussion? It seems to conclude with something like:
Perhaps now, almost 1.5 years after the last posts in that discussion and more than 2 years after the release of v1.8 it could be a good time to re-raise the topic. Maybe it's time to do the change it in 1.12? |
Yes, that looks like the right discussion. It does look like it petered out without a resolution -- I would suggest re-raising it on the mailing list. |
PR #6054 implements a deprecation warning for this change, by the way. The idea would be to warn in 1.12, then implement in 1.13. |
Closing as a duplicate of gh-5407. |
It seems that the promised change of
diag
/diagonal
to return a writeable view was forgotten in 1.10 and 1.11.Is the fix as easy as changing the flag on creation?
The text was updated successfully, but these errors were encountered: