Skip to content

Additional space in 0d array repr #9185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lesteve opened this issue May 30, 2017 · 5 comments
Closed

Additional space in 0d array repr #9185

lesteve opened this issue May 30, 2017 · 5 comments

Comments

@lesteve
Copy link
Contributor

lesteve commented May 30, 2017

Snippet:

import numpy as np
print(repr(np.array(1.)))

Output on 1.12.1:

array(1.0)

Output on master:

array( 1.0)

Note the space before 1.0.

git bisect gives that the commit introducing the change is d2b06fe.

Probably not such a big deal, but I guess it was not intentional. We noticed because it was breaking one of our doctest on scikit-learn.
@lesteve lesteve mentioned this issue May 30, 2017
Closed
@lesteve
Copy link
Contributor Author

lesteve commented May 30, 2017

FWIW 1.13.0rc2 is not affected by this.

@rkern
Copy link
Member

rkern commented May 30, 2017

I believe that #9139 is intended to fix this.

@lesteve
Copy link
Contributor Author

lesteve commented May 30, 2017

Good point, I search for an existing issue but I missed that. Looking at #9139 it will indeed fix this issue while at the same break more of our doctests. We can probably work around this in some way or another though.

@amueller amueller mentioned this issue Jun 19, 2017
Merged
@lesteve
Copy link
Contributor Author

lesteve commented Sep 29, 2017

@ahaldane @eric-wieser @charris this one can be closed now that #9139 has been merged.

@ahaldane
Copy link
Member

Thanks, closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rkern @lesteve @ahaldane