WIP,BUG: ensure that casting to void is properly checked. #13646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
commented
May 27, 2019
| if (i != NPY_DATETIME) { | ||
| /* | ||
| * Bool -> <Anything> except datetime (since | ||
| * it conceptually has no zero) | ||
| */ | ||
| _npy_can_cast_safely_table[NPY_BOOL][i] = 1; | ||
| } | ||
| /* <Anything> -> Object */ | ||
| /* <Anything> -> Object is possible */ |
There was a problem hiding this comment.
Out of scope, but is this true for object->object?
mhvk
commented
May 27, 2019
| } | ||
|
|
||
| _npy_can_cast_safely_table[NPY_STRING][NPY_UNICODE] = 1; | ||
| _npy_can_cast_safely_table[NPY_BOOL][NPY_TIMEDELTA] = 1; |
There was a problem hiding this comment.
This is already included in the loop above.
There was a problem hiding this comment.
Do you want to make a follow-up patch that removes this then, since you closed this one?
There was a problem hiding this comment.
I felt it was too small, but you're right, might as well: #13652
|
Closing in favour of #13648, as I've convinced myself this was going in the wrong direction, changing things for the general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #11114, currently the following clearly wrong things happen:
The present PR fixes it, and doesn't cause errors locally, but that is mostly because no tests are doing with casting to/from void. I'd happily add those, but what should and should not work?
EDIT: Should add that I'm not at all sure this is the right solution. Perhaps more likely the check should be different whenever from or to has fields.
fixes #11114