Skip to content

NEP: document reimplementation of NEP 34 #15323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Conversation

mattip
Copy link
Member

@mattip mattip commented Jan 13, 2020

Document the re-implementation of NEP 34 in gh-15119. Should only be merged after that PR and a trial period to make sure this time there is not too much fallout

@eric-wieser eric-wieser changed the title WIP, NEP: document reimplementation WIP, NEP: document reimplementation of NEP 34 Jan 14, 2020
@seberg seberg changed the title WIP, NEP: document reimplementation of NEP 34 NEP: document reimplementation of NEP 34 Jan 21, 2020
@seberg
Copy link
Member

seberg commented Jan 21, 2020

@mattip this can now just be put in right? Want to do the honours?

@mattip mattip merged commit b781887 into numpy:master Jan 21, 2020
@mattip
Copy link
Member Author

mattip commented Jan 21, 2020

xref gh-15119 just in case we need to revert both PRs

@mattip mattip deleted the nep-0034-2 branch November 2, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants