Skip to content

TYP: Avoid upcasting float64 in the set-ops #28241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

TYP: Avoid upcasting float64 in the set-ops #28241

merged 1 commit into from
Jan 28, 2025

Conversation

jorenham
Copy link
Member

Closes #28239

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Jan 28, 2025
@jorenham jorenham added this to the 2.2.3 release milestone Jan 28, 2025
@jorenham
Copy link
Member Author

No diff according to mypy primer 🤔

@charris charris merged commit 013ab9f into numpy:main Jan 28, 2025
70 checks passed
@charris
Copy link
Member

charris commented Jan 28, 2025

Thanks Joren.

@jorenham jorenham deleted the typing/fix-28239 branch January 28, 2025 17:45
@jorenham
Copy link
Member Author

And this time I didn't even mess up the git submodules 🤭

@charris charris mentioned this pull request Jan 28, 2025
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
41 - Static typing
Projects
None yet
Milestone
2.2.3 release
Development

Successfully merging this pull request may close these issues.

TYP: union1d outputs dtype[floating[_64Bit]] which is incompatible with dtype[float64]]
2 participants
@jorenham @charris