-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
MAINT: Bump scipy-doctest
to 1.8
#29085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dea98ff
to
cbf3851
Compare
Unfortunately, something about this change isn't a no-op. It seems more tests are getting picked up (and are thus failing)? |
Indeed :-). This one and its relatives look similar to #28023
Not sure if "Got" valus are "more correct", or it needs a This one looks genuine, too:
The whitespace is not a problem, but values do differ. Maybe it needs a - "current": "FMA3__AVX2",
+ "current": "AVX512F", |
IOW, the scipy-doctest change is a noop w.r.t 1.7.1, but numpy was pinning an older version which misses some tests. |
[skip azp] [skip actions] [skip cirrus]
Okay, the CI is green now after 425a603. I've to admit I've no idea what the |
Doc changes look right -- clearly not picked up in a long time -- thanks Evgeni! |
Bump the minimum scipy_doctest version to >=1.8.0
See https://discuss.scientific-python.org/t/scipy-doctest-select-only-doctests-or-both-doctests-and-unit-tests/1950 for the discussion, and the matching SciPy PR, scipy/scipy#23078
TL;DR: this change is currently a no-op; this is the only change needed to be forward compatible with an upcoming breaking change in
scipy-doctest
, no further action is needed in numpy itself. Unfortunately, all users who do$ spin check-docs
locally will need topip install --update scipy-doctest
--- once.